Merge pull request #2638 from nexB/2619-add-cocoapods-parsers

Add podspec.json and podfile.lock parsers

Author: pombredanne

src/formattedcode/output_csv.py

@@ -243,6 +243,7 @@ def get_package_columns(_columns=set()):
 
     # some extra columns for components
     extra_columns = [
+        'purl',
         'components',
         'owner_name',
         'reference_notes',

src/packagedcode/cocoapods.py

@@ -7,18 +7,26 @@
 # See https://aboutcode.org for more information about nexB OSS projects.
 #
 
+import hashlib
+import json
 import logging
 import re
 
 import attr
+import saneyaml
 
 from commoncode import filetype
 from packagedcode import models
+from packagedcode.licensing import get_license_matches
+from packagedcode.licensing import get_license_expression_from_matches
 from packagedcode.spec import Spec
 
+from packageurl import PackageURL
+
 """
 Handle cocoapods packages manifests for macOS and iOS
-including .podspec, Podfile and Podfile.lock files.
+and from Xcode projects, including .podspec, Podfile and Podfile.lock files,
+and .podspec.json files from https://github.com/CocoaPods/Specs.
 See https://cocoapods.org
 """
 
@@ -36,23 +44,89 @@
 
 @attr.s()
 class CocoapodsPackage(models.Package):
-    metafiles = ('*.podspec',)
-    extensions = ('.podspec',)
+    metafiles = (
+        '*.podspec',
+        '*podfile.lock',
+        '*.podspec.json',
+    )
+    extensions = (
+        '.podspec',
+        '.lock',
+    )
     default_type = 'pods'
     default_primary_language = 'Objective-C'
     default_web_baseurl = 'https://cocoapods.org'
-    default_download_baseurl = None
-    default_api_baseurl = None
+    github_specs_repo_baseurl = 'https://raw.githubusercontent.com/CocoaPods/Specs/blob/master/Specs'
+    default_cdn_baseurl='https://cdn.cocoapods.org/Specs'
 
     @classmethod
     def recognize(cls, location):
         yield parse(location)
 
     def repository_homepage_url(self, baseurl=default_web_baseurl):
-        return '{}/pods/{}'.format(baseurl, self.name)
+        return f'{baseurl}/pods/{self.name}'
 
     def repository_download_url(self):
-        return '{}/archive/{}.zip'.format(self.homepage_url, self.version)
+        if self.homepage_url:
+            return f'{self.homepage_url}/archive/{self.version}.zip'
+        elif self.reponame:
+            return f'{self.reponame}/archive/refs/tags/{self.version}.zip'
+
+    def get_api_data_url(self):
+        return self.specs_json_github_url
+
+    def get_code_view_url(self):
+        if isinstance(self.reponame, str):
+            return self.reponame+'/tree/'+self.version
+
+    def get_bug_tracking_url(self):
+        if isinstance(self.reponame, str):
+            return self.reponame+'/issues/'
+
+    def specs_json_cdn_url(self, baseurl=default_cdn_baseurl):
+        return f'{baseurl}/{self.hashed_path}/{self.name}/{self.version}/{self.name}.podspec.json'
+
+    def specs_json_github_url(self, baseurl=github_specs_repo_baseurl):
+        return f'{baseurl}/{self.hashed_path}/{self.name}/{self.version}/{self.name}.podspec.json'
+
+    @property
+    def reponame(self):
+        if isinstance(self.vcs_url, str):
+            if self.vcs_url[-4:] == '.git':
+                return self.vcs_url[:-4]
+
+    @property
+    def hashed_path(self):
+        """
+        Returns a string with a part of the file path derived from the md5 hash.
+
+        From https://github.com/CocoaPods/cdn.cocoapods.org:
+        "There are a set of known prefixes for all Podspec paths, you take the name of the pod,
+        create a SHA (using md5) of it and take the first three characters."
+        """
+        podname = self.get_podname_proper(self.name)
+        if self.name != podname:
+            name_to_hash = podname
+        else:
+            name_to_hash = self.name
+
+        hash_init = self.get_first_3_mdf_hash_characters(name_to_hash)
+        hashed_path = '/'.join(list(hash_init))
+        return hashed_path
+
+    @staticmethod
+    def get_first_3_mdf_hash_characters(podname):
+        return hashlib.md5(podname.encode('utf-8')).hexdigest()[0:3] 
+
+    @staticmethod
+    def get_podname_proper(podname):
+        """
+        Podnames in cocoapods sometimes are files inside a pods package (like 'OHHTTPStubs/Default')
+        This returns proper podname in those cases.
+        """
+        if '/' in podname:
+            return podname.split('/')[0]
+        return podname
 
 
 def is_podspec(location):
@@ -62,21 +136,64 @@ def is_podspec(location):
     return (filetype.is_file(location) and location.endswith('.podspec'))
 
 
+def is_podfile_lock(location):
+    """
+    Checks if the file is actually a podfile.lock file
+    """
+    return (filetype.is_file(location) and location.endswith(('podfile.lock', 'Podfile.lock')))
+
+def is_podspec_json(location):
+    """
+    Checks if the file is actually a podspec.json metadata file
+    """
+    return (filetype.is_file(location) and location.endswith('.podspec.json'))
+
+
+def read_podspec_json(location):
+    """
+    Reads from podspec.json file at location as JSON.
+    """
+    with open(location, "r") as file:
+        data = json.load(file)
+
+    return data
+
+
+def read_podfile_lock(location):
+    """
+    Reads from podfile.lock file at location as YML.
+    """
+    with open(location, 'r') as file:
+        data = saneyaml.load(file) 
+
+    return data
+
+
 def parse(location):
     """
-    Return a Package object from a .podspec file or None.
+    Return a Package object from:
+    1. `.podspec` files
+    2. `.podspec.json` files
+    3. `podfile.lock` files
+    or returns None otherwise.
     """
-    if not is_podspec(location):
-        return
+    if is_podspec(location):
+        podspec_object = Spec()
+        podspec_data = podspec_object.parse_spec(location)
+        return build_package(podspec_data)
+
+    if is_podspec_json(location):
+        podspec_json_data = read_podspec_json(location)
+        return build_xcode_package(podspec_json_data)
 
-    podspec_object = Spec()
-    podspec_data = podspec_object.parse_spec(location)
-    return build_package(podspec_data)
+    if is_podfile_lock(location):
+        podfile_lock_data = read_podfile_lock(location)
+        return build_xcode_package_from_lockfile(podfile_lock_data)
 
 
 def build_package(podspec_data):
     """
-    Return a Package object from a package data mapping or None.
+    Return a Package object from a podspec.json package data mapping.
     """
     name = podspec_data.get('name')
     version = podspec_data.get('version')
@@ -170,3 +287,173 @@ def parse_person(person):
         email = parsed.group('email')
 
     return name, email
+
+
+def get_sha1_file(location):
+    """
+    Get sha1 hash for a file at location.
+    """
+    with open(location, "rb") as f:
+        return hashlib.sha1(f.read()).hexdigest()
+
+
+def build_xcode_package(podspec_json_data):
+    """
+    Return a Package object from a podspec.json package data mapping.
+    """
+    name = podspec_json_data.get('name')
+    version = podspec_json_data.get('version')
+    summary = podspec_json_data.get('summary', '')
+    description = podspec_json_data.get('description', '')
+    homepage_url = podspec_json_data.get('homepage')
+    
+    license = podspec_json_data.get('license')
+    if isinstance(license, dict):
+        declared_license = ' '.join(list(license.values()))
+    else:
+        declared_license = license
+
+    source = podspec_json_data.get('source')
+    vcs_url = None
+    download_url = None
+
+    if isinstance(source, dict):
+        git_url = source.get('git', '')
+        http_url = source.get('http', '')
+        if git_url:
+            vcs_url = git_url
+        elif http_url:
+            download_url = http_url
+    
+    if not vcs_url:
+        vcs_url = source
+    
+    authors = podspec_json_data.get('authors') or {}
+    
+    license_matches = get_license_matches(query_string=declared_license)
+    if not license_matches:
+        license_expression = 'unknown'
+    else:
+        license_expression = get_license_expression_from_matches(license_matches)
+
+    if summary and not description.startswith(summary):
+        desc = [summary]
+        if description:
+            desc += [description]
+        description = '. '.join(desc)
+
+    parties = []
+    if authors:
+        if isinstance(authors, dict):
+            for key, value in authors.items():
+                party = models.Party(
+                    type=models.party_org,
+                    name=key,
+                    url=value+'.com',
+                    role='owner'
+                )
+                parties.append(party)
+        else:
+            party = models.Party(
+                type=models.party_org,
+                name=authors,
+                role='owner'
+            )
+            parties.append(party)
+    
+    extra_data = {}
+    extra_data['source'] = podspec_json_data['source']
+    dependencies = podspec_json_data.get('dependencies', '')
+    if dependencies:
+        extra_data['dependencies'] = dependencies
+    extra_data['podspec.json'] = podspec_json_data
+
+    package = CocoapodsPackage(
+        name=name,
+        version=version,
+        vcs_url=vcs_url,
+        description=description,
+        declared_license=declared_license,
+        license_expression=license_expression,
+        homepage_url=homepage_url,
+        download_url=download_url,
+        parties=parties,
+    )
+    
+    package.api_data_url = package.get_api_data_url()
+
+    return package
+
+
+def get_data_from_pods(dep_pod_version):
+    
+    if '(' in dep_pod_version:
+        podname, _, version = dep_pod_version.strip(')').partition(' (')
+    else:
+        version = None
+        podname = dep_pod_version
+        
+    if '/' in podname:
+        namespace, _, podname = podname.partition('/')
+    else:
+        namespace = None
+
+    return podname, namespace, version
+
+
+def build_xcode_package_from_lockfile(podfile_lock_data):
+    """
+    Return a Package object from a data mapping obtained from a podfile.lock
+    """
+    pods = podfile_lock_data['PODS']
+    pod_deps = []
+
+    for pod in pods:
+
+        if isinstance(pod, dict):
+            for main_pod, _dep_pods in pod.items():
+                
+                podname, namespace, version = get_data_from_pods(main_pod)
+
+                purl = PackageURL(
+                    type='pods',
+                    namespace=namespace,
+                    name=podname,
+                    version=version,
+                ).to_string()
+                
+                pod_deps.append(
+                    models.DependentPackage(
+                        purl=purl,
+                        scope='requires-dev',
+                        requirement=version,
+                        is_runtime=False,
+                        is_optional=True,
+                        is_resolved=True,
+                    )
+                )
+        
+        elif isinstance(pod, str):  
+            podname, namespace, version = get_data_from_pods(pod)
+            purl = PackageURL(
+                type='pods',
+                namespace=namespace,
+                name=podname,
+                version=version,
+            ).to_string()
+            
+            pod_deps.append(
+                models.DependentPackage(
+                    purl=purl,
+                    scope='requires-dev',
+                    requirement=version,
+                    is_runtime=False,
+                    is_optional=True,
+                    is_resolved=True,
+                )
+            )
+
+    yield CocoapodsPackage(
+        dependencies=pod_deps,
+        declared_license=None,
+    )