Skip to content

Commit 24b4329

Browse files
committed
Make Windows app testing work
Signed-off-by: Philippe Ombredanne <[email protected]>
1 parent b956772 commit 24b4329

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

.github/workflows/scancode-release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -335,12 +335,13 @@ jobs:
335335
--dest $thirdparty_dir \
336336
--sdists --use-cached-index
337337
cp dist/scancode_*.whl $release_dir
338+
mkdir -p $release_dir/etc/thirdparty
339+
cp -r etc/thirdparty $release_dir/etc/thirdparty
338340
cp -r \
339-
scancode extractcode configure \
341+
scancode.bat extractcode.bat configure.bat \
340342
*.rst \
341343
samples \
342344
*NOTICE *LICENSE *ABOUT \
343-
etc/thirdparty \
344345
$release_dir
345346
zipball=scancode-toolkit-$(git describe --tags)_py$python_dot_version-$operating_system.zip
346347
zip -r dist/$zipball $release_dir
@@ -621,8 +622,7 @@ jobs:
621622

622623
- name: test install app archive
623624
run: |
624-
for %%F in (dist/*.zip) do python etc/release/scancode_release_tests.py %%F
625-
625+
for /f %%F in (dist/*.zip) do python etc/release/scancode_release_tests.py dist/%%F
626626
627627
# publish_to_gh_release:
628628
# name: Publish to GH Release

configure.bat

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ set "REQUIREMENTS=--editable . --constraint requirements.txt"
3030
set "DEV_REQUIREMENTS=--editable .[testing] --constraint requirements.txt --constraint requirements-dev.txt"
3131
set "DOCS_REQUIREMENTS=--editable .[docs] --constraint requirements.txt"
3232
set "REL_REQUIREMENTS=--requirement etc/scripts/requirements.txt"
33-
set "PROD_REQUIREMENTS=scancode_toolkit*.whl"
3433

3534
@rem # where we create a virtualenv
3635
set "VIRTUALENV_DIR=venv"
@@ -58,7 +57,9 @@ set "CFG_BIN_DIR=%CFG_ROOT_DIR%\%VIRTUALENV_DIR%\Scripts"
5857
@rem # offline mode for scancode installation with no index at all
5958
if exist "%CFG_ROOT_DIR%\thirdparty" (
6059
set PIP_EXTRA_ARGS=--no-index --find-links "%CFG_ROOT_DIR%\thirdparty"
61-
set "CFG_REQUIREMENTS=%PROD_REQUIREMENTS%"
60+
for %%i in (scancode_toolkit*.whl) do set "CFG_REQUIREMENTS=%CFG_ROOT_DIR%\%%i[full]"
61+
@rem echo PROD_REQUIREMENTS: %PROD_REQUIREMENTS%
62+
@rem set "CFG_REQUIREMENTS=%PROD_REQUIREMENTS%"
6263
) else (
6364
set "CFG_REQUIREMENTS=%REQUIREMENTS%"
6465
)

etc/release/scancode_release_tests.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
on_windows = "win32" in str(sys.platform).lower()
1818

1919

20-
2120
def run_app_smoke_tests(app_archive):
2221
"""
2322
Run basic "smoke" scancode tests for the app release archive `app_archive`
@@ -46,18 +45,13 @@ def run_app_smoke_tests(app_archive):
4645
with open("some.file", "w") as sf:
4746
sf.write("license: gpl-2.0")
4847

49-
5048
print(f"Configuring scancode for release: {app_archive}")
5149
cpath = os.path.join(extract_loc, "configure")
52-
if on_windows:
53-
cpath += ".bat"
5450

5551
run_command([cpath])
5652

5753
# minimal tests: update when new scans are available
5854
scpath = os.path.join(extract_loc, "scancode")
59-
if on_windows:
60-
scpath += ".bat"
6155

6256
args = [
6357
scpath,

0 commit comments

Comments
 (0)