#413 Improve parent directory tests expectations for Windows

 * test a posix version of the paths for portable assertions

Signed-off-by: Philippe Ombredanne <[email protected]>

Author: pombredanne

tests/commoncode/test_fileutils.py

@@ -671,87 +671,117 @@ def test_parent_directory_on_path_and_location_1(self):
         test_file = 'a/.a/file'
         expected_name = 'a/.a/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_2(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'a/.a/'
         expected_name = 'a/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_3(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'a/b/.a.b'
         expected_name = 'a/b/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_4(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'a/b/a.tag.gz'
         expected_name = 'a/b/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_5(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'a/b/'
         expected_name = 'a/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_6(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'a/f.a'
         expected_name = 'a/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_7(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'a/'
         expected_name = '/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_8(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'f.a/a.c'
         expected_name = 'f.a/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_9(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'f.a/'
         expected_name = '/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)
 
     def test_parent_directory_on_path_and_location_10(self):
         test_dir = self.get_test_loc('fileutils/basename')
         test_file = 'tst'
         expected_name = '/'
         result = fileutils.parent_directory(test_file)
+        result = fileutils.as_posixpath(result)
         assert expected_name == result
+
         result = fileutils.parent_directory((os.path.join(test_dir, test_file)))
+        result = fileutils.as_posixpath(result)
         assert result.endswith(expected_name)