Only show detection logs on diagnostics option

Only show license detection logs when --license-text-diagnostics is enabled.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

Author: AyanSinhaMahapatra

src/licensedcode/detection.py

@@ -425,6 +425,9 @@ def dict_fields(attr, value):
             if attr.name == 'file_region':
                 return False
 
+            if attr.name == 'detection_log' and not license_text_diagnostics:
+                return False
+
             return True
 
         data_matches = []
@@ -470,7 +473,7 @@ def from_license_detection_mapping(
 
         detection = cls(
             license_expression=license_detection_mapping["license_expression"],
-            detection_log=license_detection_mapping["detection_log"],
+            detection_log=license_detection_mapping.get("detection_log", []) or None,
             matches=matches,
             file_region=None,
         )
@@ -589,7 +592,7 @@ class UniqueDetection:
     files = attr.ib(factory=list)
 
     @classmethod
-    def get_unique_detections(cls, license_detections):
+    def get_unique_detections(cls, license_detections, license_text_diagnostics):
         """
         Return all unique UniqueDetection from a ``license_detections`` list of
         LicenseDetection.
@@ -609,7 +612,7 @@ def get_unique_detections(cls, license_detections):
                 cls(
                     identifier=detection.identifier_with_expression,
                     license_expression=detection_mapping["license_expression"],
-                    detection_log=detection_mapping["detection_log"],
+                    detection_log=detection_mapping.get("detection_log", []) or [],
                     matches=detection_mapping["matches"],
                     detection_count=len(file_regions),
                     files=file_regions,
@@ -618,12 +621,16 @@ def get_unique_detections(cls, license_detections):
 
         return unique_license_detections
 
-    def to_dict(self):
+    def to_dict(self, license_text_diagnostics):
 
         def dict_fields(attr, value):
+
             if attr.name == 'files':
                 return False
 
+            if attr.name == 'detection_log' and not license_text_diagnostics:
+                return False
+
             return True
 
         return attr.asdict(self, filter=dict_fields)

src/licensedcode/plugin_license.py

@@ -151,7 +151,7 @@ def get_scanner(
             unknown_licenses=unknown_licenses,
         )
 
-    def process_codebase(self, codebase, **kwargs):
+    def process_codebase(self, codebase, license_text_diagnostics, **kwargs):
         """
         Post-process ``codebase`` to follow referenced filenames to license
         matches in other files.
@@ -180,7 +180,10 @@ def process_codebase(self, codebase, **kwargs):
             return
 
         license_detections = collect_license_detections(codebase)
-        unique_license_detections = UniqueDetection.get_unique_detections(license_detections)
+        unique_license_detections = UniqueDetection.get_unique_detections(
+            license_detections=license_detections,
+            license_text_diagnostics=license_text_diagnostics,
+        )
 
         if TRACE:
             logger_debug(
@@ -211,7 +214,7 @@ def process_codebase(self, codebase, **kwargs):
             detections=unique_license_detections,
         )
         codebase.attributes.license_detections.extend([
-            unique_detection.to_dict()
+            unique_detection.to_dict(license_text_diagnostics=license_text_diagnostics)
             for unique_detection in unique_license_detections
         ])