Remove unnecessary path check during the second pass on the codebase #1007

Signed-off-by: Jono Yang <[email protected]>

Author: JonoYang

src/scancode/plugin_ignore.py

@@ -64,24 +64,24 @@ def process_codebase(self, codebase, ignore=(), **kwargs):
         }
 
         ignorable = partial(is_ignored, ignores=ignores)
-        rid_to_remove = []
+        rids_to_remove = []
         remove_resource = codebase.remove_resource
 
         # First, walk the codebase from the top-down and collect the rids of
         # Resources that can be removed.
         for resource in codebase.walk(topdown=True):
             if ignorable(resource.path):
                 for child in resource.children(codebase):
-                    rid_to_remove.append(child.rid)
-                rid_to_remove.append(resource.rid)
+                    rids_to_remove.append(child.rid)
+                rids_to_remove.append(resource.rid)
 
         # Then, walk bottom-up and remove the ignored Resources from the
         # Codebase if the Resource's rid is in our list of rid's to remove.
         for resource in codebase.walk(topdown=False):
-            if ignorable(resource.path):
-                if resource.rid in rid_to_remove:
-                    rid_to_remove.remove(resource.rid)
-                    remove_resource(resource)
+            resource_rid = resource.rid
+            if resource_rid in rids_to_remove:
+                rids_to_remove.remove(resource_rid)
+                remove_resource(resource)
 
 
 def is_ignored(location, ignores):