Skip to content

Commit 58ef3a9

Browse files
committed
Use correct assert call
Signed-off-by: Philippe Ombredanne <[email protected]>
1 parent ec8fa50 commit 58ef3a9

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

tests/summarycode/test_summarizer.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from summarycode.summarizer import get_primary_language
2222
from summarycode.summarizer import get_holders_from_copyright
2323

24-
2524
pytestmark = pytest.mark.scanslow
2625

2726

@@ -173,7 +172,6 @@ def test_summary_without_copyright_or_holders(self):
173172
])
174173
check_json_scan(expected_file, result_file, remove_uuid=True, remove_file_date=True, regen=REGEN_TEST_FIXTURES)
175174

176-
177175
def test_remove_from_tallies(self):
178176
tallies = [
179177
{
@@ -205,7 +203,7 @@ def test_remove_from_tallies(self):
205203
}
206204
]
207205
result_1 = remove_from_tallies(test_entry_1, copy(tallies))
208-
assert(result_1, expected_1)
206+
assert result_1 == expected_1
209207

210208
test_entry_2 = [
211209
{
@@ -224,7 +222,7 @@ def test_remove_from_tallies(self):
224222
},
225223
]
226224
result_2 = remove_from_tallies(test_entry_2, copy(tallies))
227-
assert(result_2, expected_2)
225+
assert result_2 == expected_2
228226

229227
test_entry_3 = 'apache-2.0'
230228
expected_3 = [
@@ -238,7 +236,7 @@ def test_remove_from_tallies(self):
238236
}
239237
]
240238
result_3 = remove_from_tallies(test_entry_3, copy(tallies))
241-
assert(result_3, expected_3)
239+
assert result_3 == expected_3
242240

243241
def test_get_primary_language(self):
244242
language_tallies = [
@@ -257,13 +255,13 @@ def test_get_primary_language(self):
257255
]
258256
expected_1 = 'Python'
259257
result_1 = get_primary_language(language_tallies)
260-
assert(result_1, expected_1)
258+
assert result_1 == expected_1
261259

262260
def test_get_holders_from_copyright(self):
263261
test_copyright = 'Copyright (c) 2017, The University of Chicago. All rights reserved.'
264262
expected_1 = ['The University of Chicago']
265263
result_1 = get_holders_from_copyright(test_copyright)
266-
assert(result_1, expected_1)
264+
assert result_1 == expected_1
267265

268266
test_copyrights = [
269267
'Copyright (c) 2017, The University of Chicago. All rights reserved.',
@@ -272,4 +270,4 @@ def test_get_holders_from_copyright(self):
272270
]
273271
expected_2 = ['The University of Chicago', 'MIT', 'Apache Software Foundation']
274272
result_2 = get_holders_from_copyright(test_copyrights)
275-
assert(result_2, expected_2)
273+
assert result_2 == expected_2

0 commit comments

Comments
 (0)