Include is_builtin flag if there are additional licenses

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

Author: AyanSinhaMahapatra

src/licensedcode/cache.py

@@ -182,6 +182,12 @@ def load_or_build(
             # TODO: handle unable to lock in a nicer way
             raise
 
+    @property
+    def has_additional_licenses(self):
+        cache = get_cache()
+        if cache.additional_license_directory or cache.additional_license_plugins:
+            return True
+
 
 def build_index(
     licenses_db=None,

src/licensedcode/license_db.py

@@ -130,13 +130,16 @@ def generate_details(output_path, environment, licenses, test=False):
 
     ``test`` is to generate a stable output for testing only
     """
+    from licensedcode.cache import get_cache
+    include_builtin = get_cache().has_additional_licenses
+
     if test:
         base_context_mapping = base_context_test
     else:
         base_context_mapping = base_context
     license_details_template = environment.get_template("license_details.html")
     for lic in licenses.values():
-        license_data = lic.to_dict(include_text=False, include_builtin=False)
+        license_data = lic.to_dict(include_text=False, include_builtin=include_builtin)
         html = license_details_template.render(
             **base_context_mapping,
             license=lic,
@@ -206,7 +209,7 @@ def generate(
 
 def scancode_license_data(path):
     """
-    Dump license data from scancode licenses to the directory ``value`` passed
+    Dump license data from scancode licenses to the directory ``path`` passed
     in from command line.
 
     Dumps data in JSON, YAML and HTML formats and also dumps the .LICENSE file
@@ -220,7 +223,7 @@ def scancode_license_data(path):
 @click.command(name='scancode-license-data')
 @click.option(
     '--path',
-    type=click.Path(exists=False, readable=True, file_okay=False, resolve_path=True, path_type=str),
+    type=click.Path(exists=False, writable=True, file_okay=False, resolve_path=True, path_type=str),
     metavar='DIR',
     help='Dump the license data in this directory in the LicenseDB format and exit. '
             'Creates the directory if it does not exist. ',
@@ -233,7 +236,9 @@ def dump_scancode_license_data(
     *args,
     **kwargs,
 ):
-    """Reindex scancode licenses and exit"""
+    """
+    Dump scancode license data in various formats, and the licenseDB static website at `path`.
+    """
     scancode_license_data(path=path)
 
 

src/licensedcode/plugin_license.py

@@ -161,20 +161,17 @@ def process_codebase(self, codebase, **kwargs):
         cche = cache.get_cache()
 
         cle = codebase.get_or_create_current_header()
-        has_additional_licenses = False
 
         if cche.additional_license_directory:
             cle.extra_data['additional_license_directory'] = cche.additional_license_directory
-            has_additional_licenses = True
 
         if cche.additional_license_plugins:
             cle.extra_data['additional_license_plugins'] = cche.additional_license_plugins
-            has_additional_licenses = True
 
-        if TRACE and has_additional_licenses:
+        if TRACE and cche.has_additional_licenses:
             logger_debug(
                 f'add_referenced_filenames_license_matches: additional_licenses',
-                f'has_additional_licenses: {has_additional_licenses}\n',
+                f'has_additional_licenses: {cche.has_additional_licenses}\n',
                 f'additional_license_directory: {cche.additional_license_directory}\n',
                 f'additional_license_plugins : {cche.additional_license_plugins}'
             )