Test as result == expected not the other way

This is the new pytest way

Signed-off-by: Philippe Ombredanne <[email protected]>

Author: pombredanne

src/scancode/cli_test_utils.py

@@ -195,7 +195,7 @@ def check_json_scan(
     # TODO: remove sort, this should no longer be needed
     expected = json.dumps(expected, indent=2, sort_keys=True, separators=(',', ': '))
     results = json.dumps(results, indent=2, sort_keys=True, separators=(',', ': '))
-    assert expected == results
+    assert results == expected
 
 
 def load_json_result(location, remove_file_date=False):
@@ -297,7 +297,7 @@ def check_jsonlines_scan(
 
     expected = json.dumps(expected, indent=2, separators=(',', ': '))
     results = json.dumps(results, indent=2, separators=(',', ': '))
-    assert expected == results
+    assert results == expected
 
 
 def streamline_jsonlines_scan(scan_result, remove_file_date=False):

tests/licensedcode/test_detection_validate.py

@@ -164,7 +164,7 @@ def check_ignorable_clues(rule, regen=False):
     expected = dict([(k, v) for k, v in sorted(expected.items()) if v])
 
     try:
-        assert expected == results
+        assert results == expected
     except:
         # On failure, we compare againto get additional failure details such as
         # a clickable text_file path