Ensure that generic packages are recognized #660

 * and this even if there is specific parser yet for this

Signed-off-by: Philippe Ombredanne <[email protected]>

Author: pombredanne

src/packagedcode/models.py

@@ -892,7 +892,7 @@ def recognize(cls, location):
 
         Sub-classes should override to implement their own package recognition.
         """
-        return
+        return cls()
 
     @property
     def component_version(self):

src/packagedcode/recognize.py

@@ -97,7 +97,8 @@ def recognize_package(location):
         if type_matched and mime_matched and extension_matched:
             # we return the first match in the order of PACKAGE_TYPES
             logger_debug('all matching: package is of type:', package_type)
-
-            return package_type.recognize(location)
+            recognized = package_type.recognize(location)
+            logger_debug('all matching: recognized as:', repr(recognized))
+            return recognized
 
         logger_debug('no match: package is not of known type:', package_type)

tests/packagedcode/test_recognize.py

@@ -85,10 +85,10 @@ def test_recognize_package_tarball(self):
         package = recognize_package(test_file)
         assert isinstance(package, packagedcode.models.TarPackage)
 
-    def test_recognize_cpan_manifest_is_not_yet_supported(self):
+    def test_recognize_cpan_manifest_as_plain_package(self):
         test_file = self.get_test_loc('cpan/MANIFEST')
         package = recognize_package(test_file)
-        assert not package
+        assert isinstance(package, packagedcode.models.CpanModule)
 
     def test_recognize_maven_dot_pom(self):
         test_file = self.get_test_loc('m2/aspectj/aspectjrt/1.5.3/aspectjrt-1.5.3.pom')