- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 613
 
Description
Note that package.declared_license can be any data structure. It has been confusing to several because "declared license" is used differently by other orgs, such as SPDX.
Rename to: extracted_license_statement
The original text and data structure in a software package manifest that indicates the applicable license.  This value is not necessarily a key to any license list, and it is not validated.
package.license_expression is A single detected license expression using our keys.
Rename to: package.declared_license_expression
This is the primary license expression as determined from the declaration(s) of  the authors of the package.
create a parallel field called
package.declared_license_expression_spdx
where the expression will use SPDX identifiers.
We should also update the license field names on the Resource model to reflect the changes we are making to the license field names on the Package model. This would mean that:
Resource.licenses should be renamed to Resource.license_detections
Resource.license_expressions should be renamed Resource.detected_license_expressions
Resource.detected_license_expressions_spdx should be added. This field contains the the same data as Resource.detected_license_expressions but with SPDX identifiers.
There is also a new codebase-level field we should add named license_references. This would be a list of unique license records detected during a scan.
Older comments here:
It may be an good idea to keep track of the primary license for a package.
For instance,
a package is under mit but contain test/not-deployed code which is under gpl-2.0.
It may be a good idea to report this package's primary license as mit instead of mit AND gpl-2.0
OR better, mit AND (gpl-2.0) so that users know the primary license is mit and the secondary is gpl-2.0 (meaning code that don't affect the primary license).
Another example,
think of a debian copyright file:
adwaita-icon-theme/copyright
This package was originally debianized by Takuo KITAME <[email protected]> on
Fri, 17 Jan 2003 14:57:28 +0900.
Andreas Henriksson <[email protected]> later reused the gnome-icon-theme
packaging for the new adwaita-icon-theme package name.
It was downloaded from <http://download.gnome.org/sources/adwaita-icon-theme/>
Files: *
Copyright:
 © 2002-2014:
 .
  Full Color Icons
  ================
 .
  Ulisse Perusin <[email protected]>
  Riccardo Buzzotta <[email protected]>
  Josef Vybíral <[email protected]>
  Hylke Bons <[email protected]>
  Ricardo González <[email protected]>
  Lapo Calamandrei <[email protected]>
  Rodney Dawes <[email protected]>
  Luca Ferretti <[email protected]>
  Tuomas Kuosmanen <[email protected]>
  Andreas Nilsson <[email protected]>
  Jakub Steiner <[email protected]>
 .
  Some external 3D Assets used:
  Geraldo Cockerhan - http://www.blendswap.com/blends/view/40495 CCBYSA
 .
  Symbolic Icons
  ==============
 .
  Metaphors
  ---------
  Claire Alexander <[email protected]>
  Hylke Bons <[email protected]>
  Darren Wilson <[email protected]>
 .
  Artwork
  -------
  Jakub Steiner <[email protected]>
  Lapo Calamandrei <[email protected]>
  Hylke Bons <[email protected]>
 .
License: CC-BY-SA-3.0 or LGPL-3
 This work is licenced under the terms of either the GNU LGPL v3 or
 Creative Commons Attribution-Share Alike 3.0 United States License.
 .
 To view a copy of the CC-BY-SA licence, visit
 http://creativecommons.org/licenses/by-sa/3.0/ or send a letter to Creative
 Commons, 171 Second Street, Suite 300, San Francisco, California 94105, USA.
 .
 When attributing the artwork, using "GNOME Project" is enough.
 Please link to http://www.gnome.org where available.
Comment:
 See below for the full text of the CC-BY-SA-3.0.
 .
 On Debian GNU/Linux systems, the complete text of the GNU Lesser General
 Public License can be found in `/usr/share/common-licenses/LGPL-3'.
Files:
 po/*
Copyright:
 © 2004 Abdulaziz Al-Arfaj
.
.
.
 © 2004 Åsmund Skjæveland
 © 2004-2014 Žygimantas Beručka
License: CC-BY-SA-3.0-US or LGPL-3
 This work is licenced under the terms of either the GNU LGPL v3 or
 Creative Commons Attribution-Share Alike 3.0 United States License.
 .
 To view a copy of the CC-BY-SA licence, visit
 http://creativecommons.org/licenses/by-sa/3.0/ or send a letter to Creative
 Commons, 171 Second Street, Suite 300, San Francisco, California 94105, USA.
 .
 When attributing the artwork, using "GNOME Project" is enough.
 Please link to http://www.gnome.org where available.
Files:
 po/tk.po
Copyright:
 © 2004 Free Software Foundation
 © 2004 Gurban Mühemmet Tewekgeli and Kakilik - Turkmen free software developers community
License: GPL-unspecified
 This file is distributed under the terms of GNU General Public License (GPL)
Comment:
 On Debian systems, the complete text of the GNU General
 Public License can be found in `/usr/share/common-licenses/GPL'.
Files:
 src/fullcolor/accessories-dictionary.svg
Copyright:
 © Ulisse Perusin
 © Lapo Calamandrei
 © SoylentGreen
 © Luigi Chiesa
 © unknown contributor to FreeSeamlessTextures.com
License: GFDL-1.2+ or CC-BY-SA-3.0-Unported or CC-BY-SA-2.0-IT, and CC-BY-3.0-US
License: CC-BY-SA-3.0-Unported
 This file is licensed under the Creative Commons Attribution-Share
 Alike 3.0 Unported license.
 .
 You are free:
 .
 • to share – to copy, distribute and transmit the work
 • to remix – to adapt the work
 .
 Under the following conditions:
 • attribution – You must attribute the work in the manner specified
   by the author or licensor (but not in any way that suggests that they
   endorse you or your use of the work).
 • share alike – If you alter, transform, or build upon this work,
   you may distribute the resulting work only under the same or similar
   license to this one.
As we can see from the above example, we should capture the primary license and report as, for instance, CC-BY-SA-3.0 or LGPL-3 (GPL-unspecified AND GFDL-1.2+ or CC-BY-SA-3.0-Unported or CC-BY-SA-2.0-IT, and CC-BY-3.0-US AND CC-BY-SA-3.0-Unported) instead of reported all the
CC-BY-SA-3.0 or LGPL-3
GPL-unspecified
GFDL-1.2+ or CC-BY-SA-3.0-Unported or CC-BY-SA-2.0-IT, and CC-BY-3.0-US
CC-BY-SA-3.0-Unported
so that user get easily identify which is the primary license for the package.