Invalid copyright not detected

[pombredanne]

[C] The Regents of the University of Michigan and Merit Network, Inc. 1992, 1993, 1994, 1995 All Rights Reserved is rare and not detected because [C] is not a valid copyright "sign"

We have a few other cases in https://github.com/search?q="Copyright+[C]"&type=code

The only sane resolution I can think of is to normalize these warts in text preparation:

• replace [C] The Regents of the University by (C) The Regents of the University
• replace Copyright [c] by Copyright (c) in all character cases.

[C] cannot be/is not a valid sign and this would otherwise trigger a badzillion of false positives as seen in https://github.com/search?q="[C]"&type=code (actually only millions, not badzillions)

[vaibhavyadav-dev]

I'm taking this one @pombredanne

[vaibhavyadav-dev]

@pombredanne If I'm right, I've just to make changes as you suggest or this require anything else, if anything else required you can tell me I'm beginner and want to make good contributions.

[pombredanne]

@CaptainTron You could start by crafting the unit tests that fail for now
Then check this https://github.com/nexB/scancode-toolkit/blob/79aae3481833de80913383b2aa21fc8cdfb9813a/src/cluecode/copyrights.py#L3987

[vaibhavyadav-dev]

@CaptainTron You could start by crafting the unit tests that fail for now Then check this

https://github.com/nexB/scancode-toolkit/blob/79aae3481833de80913383b2aa21fc8cdfb9813a/src/cluecode/copyrights.py#L3987

@pombredanne can you elaborate a bit more, I'm not getting as of now, as what unit test to look for, I've gone through that line and doc, still I'm confused!.

[arshad-muhammad]

@pombredanne since the problem is not closed, i'm working on this.

[pombredanne]

@arshad-muhammad Thanks... You may want to start NOT from the develop/ branch but rather from this other branch that has many new improvements:

• https://github.com/aboutcode-org/scancode-toolkit/tree/misc-copyrights2
  which is part of this PR:
• Improve Copyright Detection #3929

[arshad-muhammad]

Thank you for the guidance, @pombredanne I’ll switch to the misc-copyrights2 branch and review the improvements there. I’ll proceed with implementing the normalization of [C] to (C) and similar cases as discussed. I'll keep you updated on my progress.

[arshad-muhammad]

@pombredanne i did my first PR just let me know if its correct or where i went wrong.