Add spacing before blocks and keywords #168

* Add comments and fix spacing.

Signed-off-by: Jillian Daguil <[email protected]>

Author: jdaguil

.eslintrc.json

@@ -51,6 +51,18 @@
                 ]
             }
         ],
-        "space-infix-ops": ["error", {"int32Hint": false}]
+        "space-infix-ops": [
+            "error",
+            {
+                "int32Hint": false
+            }
+        ],
+        "space-before-blocks": "error",
+        "keyword-spacing": [
+            "error",
+            {
+                "before": true
+            }
+        ]
     }
 }

assets/app/js/aboutCodeDB.js

@@ -15,7 +15,6 @@
  */
 
 
-// Load Sequelize and create an in-memory database
 const Sequelize = require('sequelize');
 const fs = require('fs');
 const JSONStream = require('JSONStream');
@@ -26,6 +25,10 @@ const {parentPath} = require('./models/databaseUtils');
  * Manages the database created from a ScanCode JSON input.
  * The database contains tables for both flattened and unflattened data
  *
+ * The config will load an existing database or will create a new, empty
+ * database if none exists. For a new database, the data is loaded from a JSON
+ * file by calling addFromJson(jsonFileName).
+ *
  * @param config
  * @param config.dbName
  * @param config.dbUser

assets/app/js/aboutCodeDashboard.js

@@ -259,7 +259,7 @@ class AboutCodeDashboard extends View {
   static formatData(names) {
     // Sum the total number of times the name appears
     let count = {};
-    $.each(names, function(i, name){
+    $.each(names, function(i, name) {
       count[name] = count[name] + 1 || 1;
     });
 

assets/app/js/helpers/barChart.js

@@ -164,7 +164,7 @@ class BarChart {
 
     let maxStr = '';
     $.each(names, function(i, name) {
-      if(name.length > maxStr.length){
+      if (name.length > maxStr.length) {
         maxStr = name;
       }
     });
@@ -182,7 +182,7 @@ class BarChart {
 
     // Sum the total number of times the name appears
     let count = {};
-    $.each(names, function(i, name){
+    $.each(names, function(i, name) {
       count[name] = count[name] + 1 || 1;
     });
 
@@ -196,7 +196,7 @@ class BarChart {
     });
 
     // Sorts the data highest value to lowest value
-    chartData.sort(function(a,b){
+    chartData.sort(function(a,b) {
       if (a.val === b.val) {
         return a.name.localeCompare(b.name);
       } else {

assets/app/js/helpers/utils.js

@@ -23,7 +23,7 @@ class Utils {
     for (let i = 0; i < values.length; i++) {
       attributeValue = values[i][attribute];
 
-      if (!Array.isArray(attributeValue) || attributeValue.length === 0){
+      if (!Array.isArray(attributeValue) || attributeValue.length === 0) {
         attributeValue = [attributeValue];
       }
 

test/eslint.test.js

@@ -36,7 +36,7 @@ const esLintResults = engine.executeOnFiles(files).results;
 // for each failure
 describe('ESLint', () => esLintResults.forEach(({ filePath, messages }) => {
   it(`validates ${filePath}`, () => {
-    if (messages) {
+    if (messages.length > 0) {
       assert.fail(false, true, messages.map(formatError).join('\n'));
     }
   });