Address review comments

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

etc/scripts/d2d/README.rst

@@ -12,7 +12,7 @@ Usage
 
 .. code-block:: bash
 
-   ./run_mapping.sh <from-path> <to-path> [options] <output-file> <spin-db> [db-port]
+   ./map-deploy-to-develop.sh <from-path> <to-path> <output-file> [options] <spin-db> [db-port]
 
 Arguments
 ---------
@@ -41,13 +41,13 @@ Run mapping without database:
 
 .. code-block:: bash
 
-   ./run_mapping.sh ./from.tar.gz ./to.whl "" results.txt false
+   ./map-deploy-to-develop.sh ./from.tar.gz ./to.whl results.txt
 
 Run mapping with database on a custom port:
 
 .. code-block:: bash
 
-   ./run_mapping.sh ./from.tar.gz ./to.whl "Python,Java" output.txt true 5555
+   ./map-deploy-to-develop.sh ./from.tar.gz ./to.whl output.txt --options "Python,Java" --spin-db --port 5433
 
 Script Actions
 --------------
@@ -83,10 +83,10 @@ Ensure the script has execute permissions:
 .. code-block:: bash
 
       sudo su -
-      chmod +x run_d2d.sh
+      chmod +x map-deploy-to-develop.sh
 
 Then execute:
 
 .. code-block:: bash
 
-      ./run_d2d.sh ...
+      ./map-deploy-to-develop.sh ...

etc/scripts/d2d/run_d2d.sh renamed to etc/scripts/d2d/map-deploy-to-develop.sh

@@ -3,10 +3,34 @@ set -e
 
 FROM_PATH="$1"
 TO_PATH="$2"
-D2D_OPTIONS="$3"
-OUTPUT_FILE="$4"
-SPIN_DB="$5"
-DB_PORT="$6"
+OUTPUT_FILE="$3"
+
+D2D_OPTIONS=""
+SPIN_DB=false
+DB_PORT=5432
+
+
+shift 3
+while [[ "$#" -gt 0 ]]; do
+  case "$1" in
+    --options)
+      D2D_OPTIONS="$2"
+      shift 2
+      ;;
+    --spin-db)
+      SPIN_DB=true
+      shift 1
+      ;;
+    --port)
+      DB_PORT="$2"
+      shift 2
+      ;;
+    *)
+      echo "Unknown parameter: $1"
+      exit 1
+      ;;
+  esac
+done
 
 if [ -z "$FROM_PATH" ] || [ -z "$TO_PATH" ] || [ -z "$OUTPUT_FILE" ]; then
   echo "Missing required arguments!"
@@ -28,7 +52,7 @@ echo "DB_PORT: $DB_PORT"
 
 DB_STARTED=false
 
-if [ "$SPIN_DB" = "true" ]; then
+if [ "$SPIN_DB" = true ]; then
   echo "Starting Postgres container on port $DB_PORT..."
 
   docker run -d \