Skip to content

Commit 5dfb513

Browse files
committed
Update Migration and redundant check of scores
Signed-off-by: 404-geek <[email protected]>
1 parent cda5531 commit 5dfb513

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

scanpipe/migrations/0074_alter_codebaseresource_sha1_git_and_more.py renamed to scanpipe/migrations/0074_add_discovered_package_score_and_scorecard_check_models.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Generated by Django 5.1.11 on 2025-07-13 20:01
1+
# Generated by Django 5.1.11 on 2025-07-17 05:29
22

33
import django.db.models.deletion
44
import uuid
@@ -12,11 +12,6 @@ class Migration(migrations.Migration):
1212
]
1313

1414
operations = [
15-
migrations.AlterField(
16-
model_name='codebaseresource',
17-
name='sha1_git',
18-
field=models.CharField(blank=True, help_text='SHA1 checksum generated by Git, hex-encoded.', max_length=40, verbose_name='SHA1_git'),
19-
),
2015
migrations.CreateModel(
2116
name='DiscoveredPackageScore',
2217
fields=[

scanpipe/tests/test_models.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2727,10 +2727,13 @@ def test_scanpipe_scorecard_models(self):
27272727

27282728
for check in checks:
27292729
self.assertIsInstance(check.check_name, str)
2730-
if check.check_score == "-1":
2731-
self.assertEqual(check.check_score, "-1")
2732-
else:
2733-
self.assertRegex(check.check_score, r"^\d+(\.\d+)?$")
2730+
2731+
score = check.check_score
2732+
# Check if score is "-1" or a numeric string within range 0-10
2733+
self.assertTrue(
2734+
(score == "-1") or (score.isdigit() and 0 <= int(score) <= 10),
2735+
"Score must be '-1' or a number between 0 and 10"
2736+
)
27342737

27352738
def test_scanpipe_create_from_scorecard_data(self):
27362739
"""Test that create_from_scorecard_data successfully creates a package score."""

0 commit comments

Comments
 (0)