suggestions applied

Signed-off-by: NucleonGodX <[email protected]>

Author: NucleonGodX

docs/rest-api.rst

@@ -493,7 +493,7 @@ Data:
         }
     }
 
-.. _rest_api_clarity_compliance:
+.. _rest_api_license_clarity_compliance:
 
 License Clarity Compliance
 ^^^^^^^^^^^^^^^^^^^^^^^^^^

docs/tutorial_license_policies.rst

@@ -150,7 +150,7 @@ in the project:
      > ERROR: 1
        cuckoo_filter-1.0.6.tar.gz-extract/cuckoo_filter-1.0.6/README.md
     [license clarity]
-     > Alert Level: ERROR
+     > ERROR
 
 .. tip::
     In case of compliance alerts, the command returns a non-zero exit code which

scanpipe/api/views.py

@@ -482,7 +482,7 @@ def compliance(self, request, *args, **kwargs):
         return Response({"compliance_alerts": compliance_alerts})
 
     @action(detail=True, methods=["get"])
-    def clarity_compliance(self, request, *args, **kwargs):
+    def license_clarity_compliance(self, request, *args, **kwargs):
         """
         Retrieve the license clarity compliance alert for a project.
 

scanpipe/management/commands/check-compliance.py

@@ -90,7 +90,7 @@ def check_compliance(self, fail_level):
 
             if has_clarity_issue:
                 self.stderr.write("[license clarity]")
-                self.stderr.write(f" > Alert Level: {clarity_alert.upper()}")
+                self.stderr.write(f" > {clarity_alert.upper()}")
 
         return total_issues > 0
 

scanpipe/models.py

@@ -1519,8 +1519,7 @@ def get_license_clarity_compliance_alert(self):
         Return the license clarity compliance alert value for the project,
         or None if not set.
         """
-        extra_data = self.extra_data or {}
-        return extra_data.get("license_clarity_compliance_alert")
+        return self.extra_data.get("license_clarity_compliance_alert")
 
     def get_license_policy_index(self):
         """Return the policy license index for this project instance."""

scanpipe/pipes/license_clarity.py

@@ -156,7 +156,7 @@ def load_clarity_thresholds_from_file(file_path):
     file_path = Path(file_path)
 
     if not file_path.exists():
-        return None
+        return
 
     try:
         yaml_content = file_path.read_text(encoding="utf-8")
@@ -175,10 +175,10 @@ def get_project_clarity_thresholds(project):
     """
     policies_dict = project.get_policies_dict()
     if not policies_dict:
-        return None
+        return
 
     clarity_thresholds = policies_dict.get("license_clarity_thresholds")
     if not clarity_thresholds:
-        return None
+        return
 
     return ClarityThresholdsPolicy(clarity_thresholds)

scanpipe/tests/test_commands.py

@@ -1225,9 +1225,7 @@ def test_scanpipe_management_command_check_clarity_compliance_only(self):
             call_command("check-compliance", *options, stderr=out)
         self.assertEqual(cm.exception.code, 1)
         out_value = out.getvalue().strip()
-        expected = (
-            "1 compliance issues detected.\n[license clarity]\n > Alert Level: ERROR"
-        )
+        expected = "1 compliance issues detected.\n[license clarity]\n > ERROR"
         self.assertEqual(expected, out_value)
 
     def test_scanpipe_management_command_check_both_compliance_and_clarity(self):
@@ -1250,7 +1248,7 @@ def test_scanpipe_management_command_check_both_compliance_and_clarity(self):
         expected = (
             "2 compliance issues detected."
             "\n[packages]\n > ERROR: 1"
-            "\n[license clarity]\n > Alert Level: WARNING"
+            "\n[license clarity]\n > WARNING"
         )
         self.assertEqual(expected, out_value)
 

scanpipe/views.py

@@ -1210,9 +1210,8 @@ def get_context_data(self, **kwargs):
         )
         context["compliance_alerts"] = compliance_alerts
 
-        extra_data = project.extra_data or {}
-        context["license_clarity_compliance_alert"] = extra_data.get(
-            "license_clarity_compliance_alert"
+        context["license_clarity_compliance_alert"] = (
+            project.get_license_clarity_compliance_alert()
         )
 
         return context