Enable refurb validation in ruff

Signed-off-by: tdruez <[email protected]>

Author: tdruez

pyproject.toml

@@ -168,7 +168,8 @@ select = [
     "S",  # flake8-bandit
     "I",  # isort
     "C9", # McCabe complexity
-    "FIX",# flake8-fixme
+    "FIX", # flake8-fix
+    "FURB", # refurb
 ]
 ignore = ["D1", "D203", "D205", "D212", "D400", "D415"]
 

scanpipe/models.py

@@ -1184,8 +1184,7 @@ def write_input_file(self, file_object):
         file_path = Path(self.input_path / filename)
 
         with open(file_path, "wb+") as f:
-            for chunk in file_object.chunks():
-                f.write(chunk)
+            f.writelines(file_object.chunks())
 
     def copy_input_from(self, input_location):
         """

scanpipe/pipes/__init__.py

@@ -166,8 +166,7 @@ def _clean_package_data(package_data):
     package_data = package_data.copy()
     if release_date := package_data.get("release_date"):
         if type(release_date) is str:
-            if release_date.endswith("Z"):
-                release_date = release_date[:-1]
+            release_date = release_date.removesuffix("Z")
             package_data["release_date"] = datetime.fromisoformat(release_date).date()
 
     # Strip leading "codebase/" to make path compatible with

scanpipe/pipes/federatedcode.py

@@ -156,8 +156,7 @@ def add_scan_result(project, repo, package_scan_file, logger=None):
     write_to.parent.mkdir(parents=True, exist_ok=True)
     results_generator = JSONResultsGenerator(project)
     with open(write_to, encoding="utf-8", mode="w") as file:
-        for chunk in results_generator:
-            file.write(chunk)
+        file.writelines(results_generator)
 
     return relative_scan_file_path
 

scanpipe/pipes/js.py

@@ -69,7 +69,7 @@ def is_source_mapping_in_minified(resource, map_file_name):
     lines = resource.file_content.split("\n")
     total_lines = len(lines)
     # Get the last 5 lines.
-    tail = 5 if total_lines > 5 else total_lines
+    tail = min(total_lines, 5)
     return any(source_mapping in line for line in reversed(lines[-tail:]))
 
 

scanpipe/pipes/spdx.py

@@ -380,9 +380,7 @@ def date_to_iso(date_str):
         if not date_str:
             return
 
-        if date_str.endswith("Z"):
-            date_str = date_str[:-1]
-
+        date_str = date_str.removesuffix("Z")
         as_datetime = datetime.fromisoformat(date_str)
         return as_datetime.isoformat(timespec="seconds") + "Z"