Only work with "maven" package type #1763

Signed-off-by: Chin Yeung Li <[email protected]>

Author: chinyeungli

scanpipe/pipes/resolve.py

@@ -576,16 +576,17 @@ def get_pom_url_list(input_source, packages):
     pom_url_list = []
     if packages:
         for package in packages:
-            package_ns = package.get("namespace", "")
-            package_name = package.get("name", "")
-            package_version = package.get("version", "")
-            pom_url = (
-                f"https://repo1.maven.org/maven2/{package_ns.replace('.', '/')}/"
-                f"{package_name}/{package_version}/"
-                f"{package_name}-{package_version}.pom".lower()
-            )
-            pom_url_list.append(pom_url)
-    else:
+            if package.get("type") == "maven":
+                package_ns = package.get("namespace", "")
+                package_name = package.get("name", "")
+                package_version = package.get("version", "")
+                pom_url = (
+                    f"https://repo1.maven.org/maven2/{package_ns.replace('.', '/')}/"
+                    f"{package_name}/{package_version}/"
+                    f"{package_name}-{package_version}.pom".lower()
+                )
+                pom_url_list.append(pom_url)
+    if not pom_url_list:
         from urllib.parse import urlparse
 
         # Check what's the input source

scanpipe/tests/pipes/test_resolve.py

@@ -548,6 +548,7 @@ def test_scanpipe_resolve_construct_pom_url_from_filename(
     def test_scanpipe_resolve_get_pom_url_list_with_packages(self):
         packages = [
             {
+                "type": "maven",
                 "namespace": "org.apache.commons",
                 "name": "commons-lang3",
                 "version": "3.12.0",
@@ -559,6 +560,19 @@ def test_scanpipe_resolve_get_pom_url_list_with_packages(self):
         ]
         self.assertEqual(result, expected)
 
+    def test_scanpipe_resolve_get_pom_url_list_with_non_maven_packages(self):
+        packages = [
+            {
+                "type": "jar",
+                "namespace": "",
+                "name": "spring-context",
+                "version": "7.0.0",
+            }
+        ]
+        result = resolve.get_pom_url_list({}, packages)
+        expected = []
+        self.assertEqual(result, expected)
+
     def test_scanpipe_resolve_get_pom_url_list_with_maven_download_url(self):
         input_source = {
             "download_url": "https://repo1.maven.org/maven2/org/apache/commons/commons-lang3/3.12.0/commons-lang3-3.12.0.jar"