fix tests

Signed-off-by: NucleonGodX <[email protected]>

Author: NucleonGodX

scanpipe/pipes/compliance_thresholds.py

@@ -92,7 +92,9 @@ def validate_thresholds(self, threshold_dict):
             try:
                 threshold = self.THRESHOLD_TYPE(key)
             except (ValueError, TypeError):
-                type_name = "integers" if self.THRESHOLD_TYPE == int else "numbers"
+                type_name = (
+                    "integers" if issubclass(self.THRESHOLD_TYPE, int) else "numbers"
+                )
                 raise ValidationError(f"Threshold keys must be {type_name}, got: {key}")
 
             if threshold in seen:
@@ -101,7 +103,8 @@ def validate_thresholds(self, threshold_dict):
 
             if value not in ["ok", "warning", "error"]:
                 raise ValidationError(
-                    f"Compliance alert must be one of 'ok', 'warning', 'error', got: {value}"
+                    f"Compliance alert must be one of 'ok', 'warning', 'error', "
+                    f"got: {value}"
                 )
             validated[threshold] = value
 
@@ -138,7 +141,7 @@ class ScorecardThresholdsPolicy(BaseThresholdsPolicy):
 
 
 def load_thresholds_from_yaml(yaml_content, policy_class):
-    """Generic function to load thresholds from YAML."""
+    """Load thresholds from YAML."""
     data = load_yaml_content(yaml_content)
 
     if not isinstance(data, dict):
@@ -153,7 +156,7 @@ def load_thresholds_from_yaml(yaml_content, policy_class):
 
 
 def load_thresholds_from_file(file_path, policy_class):
-    """Generic function to load thresholds from file."""
+    """Load thresholds from file."""
     file_path = Path(file_path)
     if not file_path.exists():
         return

scanpipe/tests/pipes/test_compliance_thresholds.py

@@ -33,7 +33,7 @@
 
 class ClarityThresholdsPolicyTest(TestCase):
     """Test ClarityThresholdsPolicy class functionality."""
-    
+
     data = Path(__file__).parent.parent / "data"
 
     def test_valid_thresholds_initialization(self):
@@ -152,21 +152,25 @@ def test_yaml_string_invalid_yaml(self):
             load_thresholds_from_yaml(yaml_content, ClarityThresholdsPolicy)
 
     def test_load_from_existing_file(self):
-        test_file = self.data / "compliance-thresholds" / "clarity_sample_thresholds.yml"
+        test_file = (
+            self.data / "compliance-thresholds" / "clarity_sample_thresholds.yml"
+        )
         policy = load_thresholds_from_file(test_file, ClarityThresholdsPolicy)
         self.assertIsNotNone(policy)
         self.assertEqual(policy.get_alert_for_score(95), "ok")
         self.assertEqual(policy.get_alert_for_score(75), "warning")
         self.assertEqual(policy.get_alert_for_score(50), "error")
 
     def test_load_from_nonexistent_file(self):
-        policy = load_thresholds_from_file("/nonexistent/file.yml", ClarityThresholdsPolicy)
+        policy = load_thresholds_from_file(
+            "/nonexistent/file.yml", ClarityThresholdsPolicy
+        )
         self.assertIsNone(policy)
 
 
 class ScorecardThresholdsPolicyTest(TestCase):
     """Test ScorecardThresholdsPolicy class functionality."""
-    
+
     data = Path(__file__).parent.parent / "data"
 
     def test_valid_thresholds_initialization(self):
@@ -286,14 +290,17 @@ def test_yaml_string_invalid_yaml(self):
             load_thresholds_from_yaml(yaml_content, ScorecardThresholdsPolicy)
 
     def test_load_from_existing_file(self):
-        test_file = self.data / "compliance-thresholds" / "scorecard_sample_thresholds.yml"
+        test_file = (
+            self.data / "compliance-thresholds" / "scorecard_sample_thresholds.yml"
+        )
         policy = load_thresholds_from_file(test_file, ScorecardThresholdsPolicy)
         self.assertIsNotNone(policy)
         self.assertEqual(policy.get_alert_for_score(9.5), "ok")
         self.assertEqual(policy.get_alert_for_score(8.0), "warning")
         self.assertEqual(policy.get_alert_for_score(5.0), "error")
 
     def test_load_from_nonexistent_file(self):
-        policy = load_thresholds_from_file("/nonexistent/file.yml", ScorecardThresholdsPolicy)
+        policy = load_thresholds_from_file(
+            "/nonexistent/file.yml", ScorecardThresholdsPolicy
+        )
         self.assertIsNone(policy)
-