Make unique_content_id required field

- Also validate fields before saving

Signed-off-by: Keshav Priyadarshi <[email protected]>

Author: keshav-space

vulnerabilities/migrations/0090_migrate_advisory_aliases.py

@@ -86,6 +86,17 @@ def reverse_populate_new_advisory_aliases_field(apps, schema_editor):
         )
 
     operations = [
+        migrations.AlterField(
+            model_name="advisory",
+            name="unique_content_id",
+            field=models.CharField(
+                help_text="A 64 character unique identifier for the content of the advisory since we use sha256 as hex",
+                max_length=64,
+                blank=False,
+                null=False,
+            ),
+        ),
+
         # Make vulnerability relation optional
         migrations.AlterField(
             model_name="alias",

vulnerabilities/models.py

@@ -1319,7 +1319,8 @@ class Advisory(models.Model):
 
     unique_content_id = models.CharField(
         max_length=64,
-        blank=True,
+        blank=False,
+        null=False,
         help_text="A 64 character unique identifier for the content of the advisory since we use sha256 as hex",
     )
     aliases = models.ManyToManyField(
@@ -1364,9 +1365,8 @@ class Meta:
         ordering = ["date_published", "unique_content_id"]
 
     def save(self, *args, **kwargs):
-        advisory_data = self.to_advisory_data()
-        self.unique_content_id = compute_content_id(advisory_data, include_metadata=False)
-        super().save(*args, **kwargs)
+        self.full_clean()
+        return super().save(*args, **kwargs)
 
     def to_advisory_data(self) -> "AdvisoryData":
         from vulnerabilities.importer import AdvisoryData