Skip to content

Commit 09eb475

Browse files
ambuj-1211ambuj-1211
committed
correct unit test and doctest for curl importer
Signed-off-by: ambuj <[email protected]>
1 parent 87d0388 commit 09eb475

File tree

4 files changed

+96
-73
lines changed

4 files changed

+96
-73
lines changed

‎vulnerabilities/importers/curl.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def parse_advisory_data(raw_data) -> AdvisoryData:
9898
... ]
9999
... }
100100
>>> parse_advisory_data(raw_data)
101-
AdvisoryData(aliases=['CVE-2024-2379'], summary='QUIC certificate check bypass with wolfSSL', affected_packages=[AffectedPackage(package=PackageURL(type='generic', namespace='curl.se', name='curl', version=None, qualifiers={}, subpath=None), affected_version_range=GenericVersionRange(constraints=(VersionConstraint(comparator='=', version=SemverVersion(string='8.6.0')),)), fixed_version=SemverVersion(string='8.7.0'))], references=[Reference(reference_id='', url='https://curl.se/docs/CVE-2024-2379.html', severities=[VulnerabilitySeverity(system=Cvssv3ScoringSystem(identifier='cvssv3.1', name='CVSSv3.1 Base Score', url='https://www.first.org/cvss/v3-1/', notes='CVSSv3.1 base score and vector'), value='Low', scoring_elements='')]), Reference(reference_id='', url='https://hackerone.com/reports/2410774', severities=[])], date_published=datetime.datetime(2024, 3, 27, 8, 0, tzinfo=datetime.timezone.utc), weaknesses=[297], url='https://curl.se/docs/CVE-2024-2379.json')
101+
AdvisoryData(aliases=['CVE-2024-2379'], summary='QUIC certificate check bypass with wolfSSL', affected_packages=[AffectedPackage(package=PackageURL(type='generic', namespace='curl.se', name='curl', version=None, qualifiers={}, subpath=None), affected_version_range=GenericVersionRange(constraints=(VersionConstraint(comparator='=', version=SemverVersion(string='8.6.0')),)), fixed_version=SemverVersion(string='8.7.0'))], references=[Reference(reference_id='', reference_type='', url='https://curl.se/docs/CVE-2024-2379.html', severities=[VulnerabilitySeverity(system=Cvssv3ScoringSystem(identifier='cvssv3.1', name='CVSSv3.1 Base Score', url='https://www.first.org/cvss/v3-1/', notes='CVSSv3.1 base score and vector'), value='Low', scoring_elements='', published_at=None)]), Reference(reference_id='', reference_type='', url='https://hackerone.com/reports/2410774', severities=[])], date_published=datetime.datetime(2024, 3, 27, 8, 0, tzinfo=datetime.timezone.utc), weaknesses=[297], url='https://curl.se/docs/CVE-2024-2379.json')
102102
"""
103103

104104
affected = get_item(raw_data, "affected")[0] if len(get_item(raw_data, "affected")) > 0 else []

‎vulnerabilities/tests/test_data/curl/expected_curl_advisory_output1.json‎

Lines changed: 39 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,45 @@
11
{
2-
"aliases": [
2+
"aliases": [
33
"CVE-2024-2379"
4-
],
5-
"summary": "QUIC certificate check bypass with wolfSSL",
6-
"affected_packages": [
7-
{
8-
"package": {
9-
"type": "generic",
10-
"namespace": "curl.se",
11-
"name": "curl",
12-
"version": "",
13-
"qualifiers": "",
14-
"subpath": ""
15-
},
16-
"affected_version_range": "vers:generic/8.6.0",
17-
"fixed_version": "8.7.0"
18-
}
19-
],
20-
"references": [
21-
{
22-
"reference_id": "",
23-
"url": "https://curl.se/docs/CVE-2024-2379.html",
24-
"severities": [
25-
{
26-
"system": "cvssv3.1",
27-
"value": "Low",
28-
"scoring_elements": ""
29-
}
30-
]
4+
],
5+
"summary": "QUIC certificate check bypass with wolfSSL",
6+
"affected_packages": [
7+
{
8+
"package": {
9+
"type": "generic",
10+
"namespace": "curl.se",
11+
"name": "curl",
12+
"version": "",
13+
"qualifiers": "",
14+
"subpath": ""
3115
},
32-
{
33-
"reference_id": "",
34-
"url": "https://hackerone.com/reports/2410774",
16+
"affected_version_range": "vers:generic/8.6.0",
17+
"fixed_version": "8.7.0"
18+
}
19+
],
20+
"references": [
21+
{
22+
"reference_id": "",
23+
"reference_type": "",
24+
"url": "https://curl.se/docs/CVE-2024-2379.html",
25+
"severities": [
26+
{
27+
"system": "cvssv3.1",
28+
"value": "Low",
29+
"scoring_elements": ""
30+
}
31+
]
32+
},
33+
{
34+
"reference_id": "",
35+
"reference_type": "",
36+
"url": "https://hackerone.com/reports/2410774",
3537
"severities": []
3638
}
37-
],
38-
"date_published": "2024-03-27T08:00:00+00:00",
39-
"weaknesses": [295],
40-
"url": "https://curl.se/docs/CVE-2024-2379.json"
39+
],
40+
"date_published": "2024-03-27T08:00:00+00:00",
41+
"weaknesses": [
42+
295
43+
],
44+
"url": "https://curl.se/docs/CVE-2024-2379.json"
4145
}

‎vulnerabilities/tests/test_data/curl/expected_curl_advisory_output2.json‎

Lines changed: 30 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,45 @@
11
{
2-
"aliases": ["CVE-2024-0853"],
3-
"summary": "OCSP verification bypass with TLS session reuse",
2+
"aliases": [
3+
"CVE-2024-0853"
4+
],
5+
"summary": "OCSP verification bypass with TLS session reuse",
46
"affected_packages": [
57
{
6-
"package": {"type": "generic", "namespace": "curl.se", "name": "curl", "version": "", "qualifiers": "", "subpath": ""},
7-
"affected_version_range": "vers:generic/8.5.0",
8+
"package": {
9+
"type": "generic",
10+
"namespace": "curl.se",
11+
"name": "curl",
12+
"version": "",
13+
"qualifiers": "",
14+
"subpath": ""
15+
},
16+
"affected_version_range": "vers:generic/8.5.0",
817
"fixed_version": "8.6.0"
918
}
10-
],
19+
],
1120
"references": [
1221
{
13-
"reference_id": "",
14-
"url": "https://curl.se/docs/CVE-2024-0853.html",
22+
"reference_id": "",
23+
"reference_type": "",
24+
"url": "https://curl.se/docs/CVE-2024-0853.html",
1525
"severities": [
1626
{
17-
"system": "cvssv3.1",
18-
"value": "Low",
27+
"system": "cvssv3.1",
28+
"value": "Low",
1929
"scoring_elements": ""
2030
}
2131
]
22-
},
32+
},
2333
{
24-
"reference_id": "",
25-
"url": "https://hackerone.com/reports/2298922",
34+
"reference_id": "",
35+
"reference_type": "",
36+
"url": "https://hackerone.com/reports/2298922",
2637
"severities": []
27-
}
28-
],
29-
"date_published": "2024-01-31T08:00:00+00:00",
30-
"weaknesses": [299],
31-
"url": "https://curl.se/docs/CVE-2024-0853.json"
38+
}
39+
],
40+
"date_published": "2024-01-31T08:00:00+00:00",
41+
"weaknesses": [
42+
299
43+
],
44+
"url": "https://curl.se/docs/CVE-2024-0853.json"
3245
}

‎vulnerabilities/tests/test_data/curl/expected_curl_advisory_output3.json‎

Lines changed: 26 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,45 @@
11
{
2-
"aliases": ["CVE-2023-46218"],
3-
"summary": "cookie mixed case PSL bypass",
2+
"aliases": [
3+
"CVE-2023-46218"
4+
],
5+
"summary": "cookie mixed case PSL bypass",
46
"affected_packages": [
57
{
68
"package": {
7-
"type": "generic",
8-
"namespace": "curl.se",
9-
"name": "curl",
10-
"version": "",
11-
"qualifiers": "",
9+
"type": "generic",
10+
"namespace": "curl.se",
11+
"name": "curl",
12+
"version": "",
13+
"qualifiers": "",
1214
"subpath": ""
13-
},
14-
"affected_version_range": "vers:generic/7.46.0|7.47.0|7.47.1|7.48.0|7.49.0|7.49.1|7.50.0|7.50.1|7.50.2|7.50.3|7.51.0|7.52.0|7.52.1|7.53.0|7.53.1|7.54.0|7.54.1|7.55.0|7.55.1|7.56.0|7.56.1|7.57.0|7.58.0|7.59.0|7.60.0|7.61.0|7.61.1|7.62.0|7.63.0|7.64.0|7.64.1|7.65.0|7.65.1|7.65.2|7.65.3|7.66.0|7.67.0|7.68.0|7.69.0|7.69.1|7.70.0|7.71.0|7.71.1|7.72.0|7.73.0|7.74.0|7.75.0|7.76.0|7.76.1|7.77.0|7.78.0|7.79.0|7.79.1|7.80.0|7.81.0|7.82.0|7.83.0|7.83.1|7.84.0|7.85.0|7.86.0|7.87.0|7.88.0|7.88.1|8.0.0|8.0.1|8.1.0|8.1.1|8.1.2|8.2.0|8.2.1|8.3.0|8.4.0",
15+
},
16+
"affected_version_range": "vers:generic/7.46.0|7.47.0|7.47.1|7.48.0|7.49.0|7.49.1|7.50.0|7.50.1|7.50.2|7.50.3|7.51.0|7.52.0|7.52.1|7.53.0|7.53.1|7.54.0|7.54.1|7.55.0|7.55.1|7.56.0|7.56.1|7.57.0|7.58.0|7.59.0|7.60.0|7.61.0|7.61.1|7.62.0|7.63.0|7.64.0|7.64.1|7.65.0|7.65.1|7.65.2|7.65.3|7.66.0|7.67.0|7.68.0|7.69.0|7.69.1|7.70.0|7.71.0|7.71.1|7.72.0|7.73.0|7.74.0|7.75.0|7.76.0|7.76.1|7.77.0|7.78.0|7.79.0|7.79.1|7.80.0|7.81.0|7.82.0|7.83.0|7.83.1|7.84.0|7.85.0|7.86.0|7.87.0|7.88.0|7.88.1|8.0.0|8.0.1|8.1.0|8.1.1|8.1.2|8.2.0|8.2.1|8.3.0|8.4.0",
1517
"fixed_version": "8.5.0"
16-
}
17-
],
18+
}
19+
],
1820
"references": [
1921
{
20-
"reference_id": "",
21-
"url": "https://curl.se/docs/CVE-2023-46218.html",
22+
"reference_id": "",
23+
"reference_type": "",
24+
"url": "https://curl.se/docs/CVE-2023-46218.html",
2225
"severities": [
2326
{
24-
"system": "cvssv3.1",
25-
"value": "Medium",
27+
"system": "cvssv3.1",
28+
"value": "Medium",
2629
"scoring_elements": ""
2730
}
2831
]
2932
},
3033
{
31-
"reference_id": "",
32-
"url": "https://hackerone.com/reports/2212193",
34+
"reference_id": "",
35+
"reference_type": "",
36+
"url": "https://hackerone.com/reports/2212193",
3337
"severities": []
3438
}
35-
],
36-
"date_published": "2023-12-06T08:00:00+00:00",
37-
"weaknesses": [201],
39+
],
40+
"date_published": "2023-12-06T08:00:00+00:00",
41+
"weaknesses": [
42+
201
43+
],
3844
"url": "https://curl.se/docs/CVE-2023-46218.json"
3945
}

0 commit comments

Comments
 (0)