Add corner cases for get_item

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

vulnerabilities/tests/test_utils.py

@@ -23,6 +23,7 @@
 from packageurl import PackageURL
 
 from vulnerabilities.utils import AffectedPackage
+from vulnerabilities.utils import get_item
 from vulnerabilities.utils import nearest_patched_package
 from vulnerabilities.utils import split_markdown_front_matter
 
@@ -94,3 +95,17 @@ def test_split_markdown_front_matter():
 
     results = split_markdown_front_matter(text)
     assert results == expected
+
+
+def test_get_item():
+    d1 = {"a": {"b": {"c": None}}}
+    assert get_item(d1, "a", "b", "c", "d") == None
+    d2 = {"a": {"b": {"c": {"d": None}}}}
+    assert get_item(d2, "a", "b", "c", "e") == None
+    d3 = ["a", "b", "c", "d"]
+    assert get_item(d3, "a", "b") == None
+    d4 = {"a": {"b": {"c": {"d": []}}}}
+    assert get_item(d4, "a", "b", "c", "d", "e") == None
+    d5 = {"a": {"b": {"c": "d"}}}
+    assert get_item(d5, "a", "b", "c", "d") == None
+    assert get_item(d5, "a", "b", "c") == "d"

vulnerabilities/utils.py

@@ -220,9 +220,12 @@ def get_item(dictionary: dict, *attributes):
     for attribute in attributes:
         if not dictionary:
             return
+        if not isinstance(dictionary, dict):
+            logger.error("dictionary must be of type `dict`")
+            return
         if attribute not in dictionary:
             logger.error(f"Missing attribute {attribute} in {dictionary}")
-            return None
+            return
         dictionary = dictionary[attribute]
     return dictionary