Skip to content

Commit 1c38ef3

Browse files
committed
Fix affected package merge functionality
Signed-off-by: Tushar Goel <[email protected]>
1 parent b26cd93 commit 1c38ef3

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

vulnerabilities/importer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ def merge(
188188
purls.add(pkg.package)
189189
if len(purls) > 1:
190190
raise UnMergeablePackageError("Cannot merge with different purls", purls)
191-
return purls.pop(), sorted(affected_version_ranges), sorted(fixed_versions)
191+
return purls.pop(), list(affected_version_ranges), sorted(fixed_versions)
192192

193193
def to_dict(self):
194194
"""

vulnerabilities/tests/test_affected_package.py

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,19 @@ def test_affected_package_merge():
5757
),
5858
),
5959
AffectedPackage(package=PackageURL(type="npm", name="foo"), fixed_version="2.0.0"),
60+
AffectedPackage(
61+
package=PackageURL(type="npm", name="foo"),
62+
affected_version_range=GemVersionRange(
63+
constraints=(
64+
VersionConstraint(
65+
comparator=">=", version=RubygemsVersion(string="10.2.0")
66+
),
67+
VersionConstraint(
68+
comparator="<=", version=RubygemsVersion(string="10.5.0")
69+
),
70+
)
71+
),
72+
),
6073
]
6174
)
6275
expected = (
@@ -69,7 +82,13 @@ def test_affected_package_merge():
6982
VersionConstraint(comparator=">=", version=RubygemsVersion(string="5.2.0")),
7083
VersionConstraint(comparator="<=", version=RubygemsVersion(string="5.2.6.2")),
7184
)
72-
)
85+
),
86+
GemVersionRange(
87+
constraints=(
88+
VersionConstraint(comparator=">=", version=RubygemsVersion(string="10.2.0")),
89+
VersionConstraint(comparator="<=", version=RubygemsVersion(string="10.5.0")),
90+
)
91+
),
7392
],
7493
["1.0.0", "2.0.0"],
7594
)

0 commit comments

Comments
 (0)