Skip to content

Commit 3e10ff3

Browse files
authored
Merge pull request #257 from sbs2001/fix_ui
Fix UI bug with vulnerability search view's pagination
2 parents a44d173 + fc01392 commit 3e10ff3

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

vulnerabilities/forms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@ class PackageForm(forms.Form):
5353

5454
class CVEForm(forms.Form):
5555

56-
cve_id = forms.CharField(widget=forms.TextInput(attrs={"placeholder": "vulnerability id"}))
56+
vuln_id = forms.CharField(widget=forms.TextInput(attrs={"placeholder": "vulnerability id"}))

vulnerabilities/templates/vulnerabilities.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ <h1 class="title">
1212
<form action="{% url 'vulnerability_search' %}" method="get">
1313
{% load widget_tweaks %}
1414
<div class="field is-horizontal">
15-
{{form.cve_id|add_class:"input"}}
15+
{{form.vuln_id|add_class:"input"}}
1616
<button class="button is-success", type="submit">
1717
Search
1818
</button>
@@ -25,7 +25,7 @@ <h1 class="title">
2525
<section class="section is-medium has-text-centered">
2626
<div class="container">
2727
<h1 class="title" id="results">Results of your query "{{searched_for}}"</h1>
28-
<h3 class="subtitle" id="results">Total {{vulnerabilities|length}} results</h3>
28+
<h3 class="subtitle" id="results">Total {{result_size}} results</h3>
2929
</div>
3030
</section>
3131

vulnerabilities/views.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,18 @@ def get(self, request):
7575
if request.GET:
7676
vulnerabilities = self.request_to_queryset(request)
7777
pages = Paginator(vulnerabilities, 50)
78+
result_size = pages.count
7879
vulnerabilities = pages.get_page(int(self.request.GET.get("page", 1)))
7980
context["vulnerabilities"] = vulnerabilities
80-
context["searched_for"] = request.GET.get("cve_id")
81+
context["searched_for"] = request.GET.get("vuln_id")
82+
context["result_size"] = result_size
8183

8284
return render(request, self.template_name, context)
8385

8486
@staticmethod
8587
def request_to_queryset(request):
86-
if request.GET["cve_id"]:
87-
cve_id = request.GET["cve_id"]
88-
return models.Vulnerability.objects.filter(cve_id__contains=cve_id)
88+
vuln_id = request.GET["vuln_id"]
89+
return models.Vulnerability.objects.filter(cve_id__contains=vuln_id)
8990

9091

9192
class PackageUpdate(UpdateView):

0 commit comments

Comments
 (0)