Skip to content

Commit 48328f1

Browse files
committed
Do not use docker Python libraries
We use the main docker instead Signed-off-by: Philippe Ombredanne <[email protected]>
1 parent c9b9617 commit 48328f1

File tree

5 files changed

+14
-15
lines changed

5 files changed

+14
-15
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Version (next)
77
- Add Pipeline to flag ghost packages (#1533)
88
- Add logging configuration (#1533)
99
- Drop support for python 3.8 (#1533)
10+
- Drop using docker-compose and use the built-in "docker compose" instead
1011

1112

1213
Version v34.0.0

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,9 @@ docs:
129129

130130
docker-images:
131131
@echo "-> Build Docker services"
132-
docker-compose build
132+
docker compose build
133133
@echo "-> Pull service images"
134-
docker-compose pull
134+
docker compose pull
135135
@echo "-> Save the service images to a compressed tar archive in the dist/ directory"
136136
@mkdir -p dist/
137137
@docker save postgres vulnerablecode_vulnerablecode nginx | gzip > dist/vulnerablecode-images-`git describe --tags`.tar.gz

README.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,18 +66,18 @@ Getting started
6666
Run with Docker
6767
^^^^^^^^^^^^^^^^
6868

69-
First install docker and docker-compose, then run::
69+
First install docker, then run::
7070

7171
git clone https://github.com/nexB/vulnerablecode.git && cd vulnerablecode
7272
make envfile
73-
docker-compose build
74-
docker-compose up -d
75-
docker-compose run vulnerablecode ./manage.py import --list
73+
docker compose build
74+
docker compose up -d
75+
docker compose run vulnerablecode ./manage.py import --list
7676

7777
Then run an importer for nginx advisories (which is small)::
7878

79-
docker-compose exec vulnerablecode ./manage.py import vulnerabilities.importers.nginx.NginxImporter
80-
docker-compose exec vulnerablecode ./manage.py improve --all
79+
docker compose exec vulnerablecode ./manage.py import vulnerabilities.importers.nginx.NginxImporter
80+
docker compose exec vulnerablecode ./manage.py improve --all
8181

8282
At this point, the VulnerableCode app and API should be up and running with
8383
some data at http://localhost

docs/source/installation.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,20 @@ create an environment file, and build the Docker image::
4545

4646
git clone https://github.com/nexB/vulnerablecode.git && cd vulnerablecode
4747
make envfile
48-
docker-compose build
48+
docker compose build
4949

5050
.. note::
5151

5252
The image will need to be re-built when the VulnerableCode app source code is
5353
modified or updated via
54-
``docker-compose build --no-cache vulnerablecode``
54+
``docker compose build --no-cache vulnerablecode``
5555

5656
Run the App
5757
^^^^^^^^^^^
5858

5959
**Run your image** as a container::
6060

61-
docker-compose up
61+
docker compose up
6262

6363

6464
At this point, the VulnerableCode app should be running at port ``8000`` on your Docker host.
@@ -90,15 +90,15 @@ Execute a Command
9090
You can execute a one of ``manage.py`` commands through the Docker command line
9191
interface, for example::
9292

93-
docker-compose run vulnerablecode ./manage.py import --list
93+
docker compose run vulnerablecode ./manage.py import --list
9494

9595
.. note::
9696
Refer to the :ref:`command_line_interface` section for the full list of commands.
9797

9898
Alternatively, you can connect to the Docker container ``bash`` and run commands
9999
from there::
100100

101-
docker-compose run vulnerablecode bash
101+
docker compose run vulnerablecode bash
102102
./manage.py import --list
103103

104104

requirements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ django-filter==21.1
3333
djangorestframework==3.13.1
3434
django-widget-tweaks==1.4.12
3535
doc8==0.11.1
36-
docker==5.0.3
37-
dockerpty==0.4.1
3836
docopt==0.6.2
3937
docutils==0.17.1
4038
drf-spectacular==0.24.2

0 commit comments

Comments
 (0)