Skip to content

Commit 670814b

Browse files
committed
Streamline packages/all code
Use a single queryset Signed-off-by: Philippe Ombredanne <[email protected]>
1 parent 401539b commit 670814b

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

vulnerabilities/api.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,12 +476,15 @@ def bulk_search(self, request):
476476
@action(detail=False, methods=["get"])
477477
def all(self, request):
478478
"""
479-
Return the Package URLs of all packages known to be vulnerable.
479+
Return a list of Package URLs of vulnerable packages.
480480
"""
481-
vulnerable_packages = (
482-
Package.objects.vulnerable().only("package_url").distinct().with_is_vulnerable()
481+
vulnerable_purls = (
482+
Package.objects.vulnerable()
483+
.only("package_url")
484+
.order_by("package_url")
485+
.distinct()
486+
.values_list("package_url", flat=True)
483487
)
484-
vulnerable_purls = [str(package.package_url) for package in vulnerable_packages]
485488
return Response(vulnerable_purls)
486489

487490
@extend_schema(

0 commit comments

Comments
 (0)