Address review comments

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

vulnerabilities/api.py

@@ -78,6 +78,12 @@ class VulnSerializerRefsAndSummary(serializers.HyperlinkedModelSerializer):
     Lookup vulnerabilities references by aliases (such as a CVE).
     """
 
+    def to_representation(self, instance):
+        data = super().to_representation(instance)
+        aliases = [alias["alias"] for alias in data["aliases"]]
+        data["aliases"] = aliases
+        return data
+
     fixed_packages = MinimalPackageSerializer(
         many=True, source="filtered_fixed_packages", read_only=True
     )

vulnerabilities/tests/test_api.py

@@ -296,7 +296,9 @@ def setUp(self):
         vuln1 = Vulnerability.objects.create(
             summary="test-vuln1",
         )
-        alias = Alias.objects.create(alias="CVE-2019-1234", vulnerability=vuln1)
+        Alias.objects.create(alias="CVE-2019-1234", vulnerability=vuln1)
+        Alias.objects.create(alias="GMS-1234-4321", vulnerability=vuln1)
+        Alias.objects.create(alias="CVE-2029-1234", vulnerability=vuln)
         self.vuln1 = vuln1
         PackageRelatedVulnerability.objects.create(
             package=self.package,
@@ -341,7 +343,7 @@ def test_api_with_single_vulnerability_and_fixed_package(self):
                     "summary": "test-vuln1",
                     "references": [],
                     "fixed_packages": [],
-                    "aliases": [{"alias": "CVE-2019-1234"}],
+                    "aliases": ["CVE-2019-1234", "GMS-1234-4321"],
                 }
             ],
             "fixing_vulnerabilities": [
@@ -357,7 +359,7 @@ def test_api_with_single_vulnerability_and_fixed_package(self):
                             "is_vulnerable": True,
                         }
                     ],
-                    "aliases": [],
+                    "aliases": ["CVE-2029-1234"],
                 },
             ],
             "unresolved_vulnerabilities": [
@@ -367,7 +369,7 @@ def test_api_with_single_vulnerability_and_fixed_package(self):
                     "summary": "test-vuln1",
                     "references": [],
                     "fixed_packages": [],
-                    "aliases": [{"alias": "CVE-2019-1234"}],
+                    "aliases": ["CVE-2019-1234", "GMS-1234-4321"],
                 }
             ],
         }