Skip to content

Commit e33e18d

Browse files
committed
Replace long mapping reference with variable #972
Reference: #972 Signed-off-by: John M. Horan <[email protected]>
1 parent 2776cb2 commit e33e18d

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

vulnerabilities/importers/apache_kafka.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,11 @@ def to_advisory(self, advisory_page):
137137

138138
# This throws a KeyError if the opening h2 tag `id` data changes or is not in the
139139
# hard-coded affected_version_range_mapping dictionary.
140-
if affected_version_range_mapping[cve_id]["action"] == "include":
141-
140+
cve_version_mapping = affected_version_range_mapping[cve_id]
141+
if cve_version_mapping["action"] == "include":
142142
# These 2 variables (not used elsewhere) trigger the KeyError for changed/missing data.
143-
check_affected_versions_key = affected_version_range_mapping[cve_id][
144-
affected_versions
145-
]
146-
check_fixed_versions_key = affected_version_range_mapping[cve_id][fixed_versions]
143+
check_affected_versions_key = cve_version_mapping[affected_versions]
144+
check_fixed_versions_key = cve_version_mapping[fixed_versions]
147145

148146
references = [
149147
Reference(
@@ -166,15 +164,13 @@ def to_advisory(self, advisory_page):
166164
name="kafka",
167165
type="apache",
168166
),
169-
affected_version_range=affected_version_range_mapping[cve_id][
170-
"affected_version_range"
171-
],
167+
affected_version_range=cve_version_mapping["affected_version_range"],
172168
)
173169
affected_packages.append(affected_package)
174170

175-
date_published = parse(
176-
affected_version_range_mapping[cve_id]["Issue announced"]
177-
).replace(tzinfo=pytz.UTC)
171+
date_published = parse(cve_version_mapping["Issue announced"]).replace(
172+
tzinfo=pytz.UTC
173+
)
178174

179175
advisories.append(
180176
AdvisoryData(

0 commit comments

Comments
 (0)