Skip to content

Commit fbae937

Browse files
committed
Address review comment
Signed-off-by: Tushar Goel <[email protected]>
1 parent a053338 commit fbae937

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

vulnerabilities/api_v2.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,9 @@ def list(self, request, *args, **kwargs):
185185
serializer = self.get_serializer(page, many=True)
186186
data = serializer.data
187187
# Use 'self.get_paginated_response' to include pagination data
188-
return self.get_paginated_response({"purls": data})
188+
return self.get_paginated_response({"packages": data})
189189

190190
# If pagination is not applied
191191
serializer = self.get_serializer(queryset, many=True)
192192
data = serializer.data
193-
return Response({"purls": data})
193+
return Response({"packages": data})

vulnerabilities/tests/test_api_v2.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,8 @@ def test_list_packages(self):
198198
url = reverse("package-v2-list")
199199
response = self.client.get(url, format="json")
200200
self.assertEqual(response.status_code, status.HTTP_200_OK)
201-
self.assertIn("purls", response.data["results"])
202-
self.assertEqual(len(response.data["results"]["purls"]), 2)
201+
self.assertIn("packages", response.data["results"])
202+
self.assertEqual(len(response.data["results"]["packages"]), 2)
203203

204204
def test_filter_packages_by_purl(self):
205205
"""
@@ -208,8 +208,8 @@ def test_filter_packages_by_purl(self):
208208
url = reverse("package-v2-list")
209209
response = self.client.get(url, {"purl": "pkg:pypi/[email protected]"}, format="json")
210210
self.assertEqual(response.status_code, status.HTTP_200_OK)
211-
self.assertEqual(len(response.data["results"]["purls"]), 1)
212-
self.assertEqual(response.data["results"]["purls"][0]["purl"], "pkg:pypi/[email protected]")
211+
self.assertEqual(len(response.data["results"]["packages"]), 1)
212+
self.assertEqual(response.data["results"]["packages"][0]["purl"], "pkg:pypi/[email protected]")
213213

214214
def test_filter_packages_by_affected_vulnerability(self):
215215
"""
@@ -218,8 +218,8 @@ def test_filter_packages_by_affected_vulnerability(self):
218218
url = reverse("package-v2-list")
219219
response = self.client.get(url, {"affected_by_vulnerability": "VCID-1234"}, format="json")
220220
self.assertEqual(response.status_code, status.HTTP_200_OK)
221-
self.assertEqual(len(response.data["results"]["purls"]), 1)
222-
self.assertEqual(response.data["results"]["purls"][0]["purl"], "pkg:pypi/[email protected]")
221+
self.assertEqual(len(response.data["results"]["packages"]), 1)
222+
self.assertEqual(response.data["results"]["packages"][0]["purl"], "pkg:pypi/[email protected]")
223223

224224
def test_filter_packages_by_fixing_vulnerability(self):
225225
"""
@@ -228,8 +228,8 @@ def test_filter_packages_by_fixing_vulnerability(self):
228228
url = reverse("package-v2-list")
229229
response = self.client.get(url, {"fixing_vulnerability": "VCID-5678"}, format="json")
230230
self.assertEqual(response.status_code, status.HTTP_200_OK)
231-
self.assertEqual(len(response.data["results"]["purls"]), 1)
232-
self.assertEqual(response.data["results"]["purls"][0]["purl"], "pkg:npm/[email protected]")
231+
self.assertEqual(len(response.data["results"]["packages"]), 1)
232+
self.assertEqual(response.data["results"]["packages"][0]["purl"], "pkg:npm/[email protected]")
233233

234234
def test_package_serializer_fields(self):
235235
"""
@@ -276,7 +276,7 @@ def test_invalid_vulnerability_filter(self):
276276
url = reverse("package-v2-list")
277277
response = self.client.get(url, {"affected_by_vulnerability": "VCID-9999"}, format="json")
278278
self.assertEqual(response.status_code, status.HTTP_200_OK)
279-
self.assertEqual(len(response.data["results"]["purls"]), 0)
279+
self.assertEqual(len(response.data["results"]["packages"]), 0)
280280

281281
def test_invalid_purl_filter(self):
282282
"""
@@ -286,7 +286,7 @@ def test_invalid_purl_filter(self):
286286
url = reverse("package-v2-list")
287287
response = self.client.get(url, {"purl": "pkg:nonexistent/[email protected]"}, format="json")
288288
self.assertEqual(response.status_code, status.HTTP_200_OK)
289-
self.assertEqual(len(response.data["results"]["purls"]), 0)
289+
self.assertEqual(len(response.data["results"]["packages"]), 0)
290290

291291
def test_get_affected_by_vulnerabilities(self):
292292
"""

0 commit comments

Comments
 (0)