Apply suggestions from code review

Signed-off-by: Tushar Goel <[email protected]>

Author: TG1999

vulnerabilities/importers/xen.py

@@ -45,9 +45,10 @@ def to_advisories(self, xsa):
         xsa_id = xsa.get("xsa")
         references = []
         if xsa_id:
-            references.append(XsaReference.from_num_id(num_id=xsa_id))
+            references.append(XsaReference.from_number(number=xsa_id))
         title = xsa.get("title")
         for cve in xsa.get("cve") or []:
+       #TODO: https://github.com/nexB/vulnerablecode/issues/981
             if not is_cve(cve):
                 continue
             yield AdvisoryData(

vulnerabilities/references.py

@@ -29,13 +29,13 @@ def from_id(cls, xsa_id):
         )
 
     @classmethod
-    def from_num_id(cls, num_id):
+    def from_number(cls, number):
         """
-        Return a new XsaReference from an XSA-XXXX id.
+        Return a new XsaReference from an XSA number.
         """
         return cls(
-            reference_id=f"XSA-{num_id}",
-            url=f"https://xenbits.xen.org/xsa/advisory-{num_id}.html",
+            reference_id=f"XSA-{number}",
+            url=f"https://xenbits.xen.org/xsa/advisory-{number}.html",
         )