Skip to content

Commit 39350f5

Browse files
committed
Refactor test setup to use provideHttpClient APIs
Replaces HttpClientTestingModule imports with provideHttpClient and provideHttpClientTesting in test files for improved Angular test setup. This aligns with updated Angular best practices for providing HTTP client dependencies.
1 parent 876462d commit 39350f5

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

npm/ng-packs/packages/core/src/lib/tests/config-state.service.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { HttpClientTestingModule } from '@angular/common/http/testing';
1+
import { provideHttpClientTesting } from '@angular/common/http/testing';
2+
import { provideHttpClient } from '@angular/common/http';
23
import { createServiceFactory, SpectatorService } from '@ngneat/spectator/jest';
34
import { of } from 'rxjs';
45
import { AbpApplicationConfigurationService } from '../proxy/volo/abp/asp-net-core/mvc/application-configurations/abp-application-configuration.service';
@@ -121,8 +122,9 @@ describe('ConfigStateService', () => {
121122

122123
const createService = createServiceFactory({
123124
service: ConfigStateService,
124-
imports: [HttpClientTestingModule],
125125
providers: [
126+
provideHttpClient(),
127+
provideHttpClientTesting(),
126128
{ provide: CORE_OPTIONS, useValue: { skipGetAppConfiguration: true } },
127129
{
128130
provide: AbpApplicationConfigurationService,

npm/ng-packs/packages/core/src/lib/tests/permission.guard.spec.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,15 @@
1-
import { APP_BASE_HREF } from '@angular/common';
2-
import { HttpClientTestingModule } from '@angular/common/http/testing';
1+
import { provideHttpClientTesting } from '@angular/common/http/testing';
2+
import { provideHttpClient } from '@angular/common/http';
33
import { Component } from '@angular/core';
4-
import { provideRouter, Route, Router, RouterModule } from '@angular/router';
4+
import { provideRouter, Route, Router } from '@angular/router';
55
import { createSpyObject, SpyObject } from '@ngneat/spectator/jest';
66
import { of } from 'rxjs';
77
import { permissionGuard } from '../guards/permission.guard';
88
import { HttpErrorReporterService } from '../services/http-error-reporter.service';
99
import { PermissionService } from '../services/permission.service';
10-
import { RoutesService } from '../services/routes.service';
11-
import { CORE_OPTIONS } from '../tokens/options.token';
12-
import { IncludeLocalizationResourcesProvider, provideAbpCore, withOptions } from '../providers';
10+
import { provideAbpCore, withOptions } from '../providers';
1311
import { TestBed } from '@angular/core/testing';
1412
import { RouterTestingHarness } from '@angular/router/testing';
15-
import { OTHERS_GROUP } from '../tokens';
16-
import { SORT_COMPARE_FUNC, compareFuncFactory } from '../tokens/compare-func.token';
1713
import { AuthService } from '../abstracts';
1814

1915
@Component({ template: '' })
@@ -50,8 +46,9 @@ describe('authGuard', () => {
5046
permissionService = createSpyObject(PermissionService);
5147

5248
TestBed.configureTestingModule({
53-
imports: [HttpClientTestingModule],
5449
providers: [
50+
provideHttpClient(),
51+
provideHttpClientTesting(),
5552
{ provide: AuthService, useValue: mockOAuthService },
5653
{ provide: PermissionService, useValue: permissionService },
5754
{ provide: HttpErrorReporterService, useValue: httpErrorReporter },

npm/ng-packs/packages/oauth/src/lib/tests/auth.guard.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ import {
99
RouterStateSnapshot,
1010
provideRouter,
1111
} from '@angular/router';
12-
import { HttpClientTestingModule } from '@angular/common/http/testing';
12+
import { provideHttpClientTesting } from '@angular/common/http/testing';
13+
import { provideHttpClient } from '@angular/common/http';
1314
import { Component } from '@angular/core';
1415
import { TestBed } from '@angular/core/testing';
1516
import { RouterTestingHarness } from '@angular/router/testing';
@@ -64,8 +65,9 @@ describe('authGuard', () => {
6465
oAuthService = createSpyObject(OAuthService);
6566

6667
TestBed.configureTestingModule({
67-
imports: [HttpClientTestingModule],
6868
providers: [
69+
provideHttpClient(),
70+
provideHttpClientTesting(),
6971
{ provide: AuthService, useValue: authService },
7072
{ provide: OAuthService, useValue: oAuthService },
7173
provideRouter(routes),

0 commit comments

Comments
 (0)