Merge pull request #24550 from abpframework/DistributedEventBusBase_AddToInbox

Add logic to set addToInbox to true if messageId exists in event inbox

Author: EngincanV

framework/src/Volo.Abp.EventBus/Volo/Abp/EventBus/Distributed/DistributedEventBusBase.cs

@@ -43,7 +43,7 @@ protected DistributedEventBusBase(
         CorrelationIdProvider = correlationIdProvider;
     }
 
-    public IDisposable Subscribe<TEvent>(IDistributedEventHandler<TEvent> handler) where TEvent : class
+    public virtual IDisposable Subscribe<TEvent>(IDistributedEventHandler<TEvent> handler) where TEvent : class
     {
         return Subscribe(typeof(TEvent), handler);
     }
@@ -53,7 +53,7 @@ public override Task PublishAsync(Type eventType, object eventData, bool onUnitO
         return PublishAsync(eventType, eventData, onUnitOfWorkComplete, useOutbox: true);
     }
 
-    public Task PublishAsync<TEvent>(
+    public virtual Task PublishAsync<TEvent>(
         TEvent eventData,
         bool onUnitOfWorkComplete = true,
         bool useOutbox = true)
@@ -154,7 +154,7 @@ protected virtual Task OnAddToOutboxAsync(string eventName, Type eventType, obje
         return Task.CompletedTask;
     }
 
-    protected async Task<bool> AddToInboxAsync(
+    protected virtual async Task<bool> AddToInboxAsync(
         string? messageId,
         string eventName,
         Type eventType,
@@ -181,6 +181,9 @@ protected async Task<bool> AddToInboxAsync(
                     {
                         if (await eventInbox.ExistsByMessageIdAsync(messageId!))
                         {
+                            // Message already exists in the inbox, no need to add again.
+                            // This can happen in case of retries from the sender side.
+                            addToInbox = true;
                             continue;
                         }
                     }