Skip to content

Commit e58841d

Browse files
committed
Clean up and update test imports and providers
Replaces deprecated HttpClientModule with provideHttpClient and provideHttpClientTesting in breadcrumb tests, removes unused imports and declarations from card, error handler, and validation utils test files for improved clarity and maintainability.
1 parent 66471df commit e58841d

File tree

4 files changed

+5
-8
lines changed

4 files changed

+5
-8
lines changed

npm/ng-packs/packages/theme-shared/src/lib/tests/breadcrumb.component.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
RoutesService,
77
LocalizationService,
88
} from '@abp/ng.core';
9-
import { HttpClient, HttpClientModule } from '@angular/common/http';
9+
import { provideHttpClient } from '@angular/common/http';
10+
import { provideHttpClientTesting } from '@angular/common/http/testing';
1011
import { RouterModule } from '@angular/router';
1112
import { createRoutingFactory, SpectatorRouting } from '@ngneat/spectator/jest';
1213
import { BreadcrumbComponent, BreadcrumbItemsComponent } from '../components';
@@ -33,8 +34,9 @@ describe('BreadcrumbComponent', () => {
3334
component: RouterOutletComponent,
3435
stubsEnabled: false,
3536
detectChanges: false,
36-
mocks: [HttpClient],
3737
providers: [
38+
provideHttpClient(),
39+
provideHttpClientTesting(),
3840
{
3941
provide: CORE_OPTIONS,
4042
useValue: {
@@ -61,7 +63,6 @@ describe('BreadcrumbComponent', () => {
6163
declarations: [],
6264
imports: [
6365
RouterModule,
64-
HttpClientModule,
6566
LocalizationPipe,
6667
BreadcrumbComponent,
6768
BreadcrumbItemsComponent,

npm/ng-packs/packages/theme-shared/src/lib/tests/card.component.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import {
44
CardBodyComponent,
55
CardFooterComponent,
66
CardHeaderComponent,
7-
CardHeaderDirective,
87
CardTitleDirective,
98
CardImgTopDirective,
109
CardSubtitleDirective,

npm/ng-packs/packages/theme-shared/src/lib/tests/error.handler.spec.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,12 @@ import { HttpErrorReporterService } from '@abp/ng.core';
22
import { CoreTestingModule } from '@abp/ng.core/testing';
33
import { APP_BASE_HREF } from '@angular/common';
44
import { HttpErrorResponse, HttpHeaders } from '@angular/common/http';
5-
import { Component, NgModule } from '@angular/core';
5+
import { NgModule } from '@angular/core';
66
import { createServiceFactory, SpectatorService } from '@ngneat/spectator/jest';
77
import { OAuthService } from 'angular-oauth2-oidc';
88
import { of, Subject } from 'rxjs';
99
import { HttpErrorWrapperComponent } from '../components/http-error-wrapper/http-error-wrapper.component';
1010
import { ErrorHandler } from '../handlers';
11-
import { DEFAULT_ERROR_LOCALIZATIONS, DEFAULT_ERROR_MESSAGES } from '../constants/default-errors';
1211
import { ConfirmationService } from '../services';
1312
import { CUSTOM_ERROR_HANDLERS, HTTP_ERROR_CONFIG } from '../tokens/http-error.token';
1413
import { CustomHttpErrorHandlerService } from '../models';

npm/ng-packs/packages/theme-shared/src/lib/tests/validation-utils.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@ import { AbpApplicationConfigurationService, ConfigStateService } from '@abp/ng.
22
import { CoreTestingModule } from '@abp/ng.core/testing';
33
import { HttpClient } from '@angular/common/http';
44
import { Component, Injector } from '@angular/core';
5-
import { Validators } from '@angular/forms';
65
import { createComponentFactory, Spectator } from '@ngneat/spectator/jest';
76
import { OAuthService } from 'angular-oauth2-oidc';
87
import { of } from 'rxjs';
98
import { getPasswordValidators, validatePassword } from '../utils';
10-
import { PasswordRule } from '../models/validation';
119

1210
@Component({ template: '', selector: 'abp-dummy' })
1311
class DummyComponent {}

0 commit comments

Comments
 (0)