fix: add format for import-name

Signed-off-by: Henry Schreiner <[email protected]>

Author: henryiii

src/validate_pyproject/formats.py

@@ -8,6 +8,7 @@
 """
 
 import builtins
+import keyword
 import logging
 import os
 import re
@@ -400,3 +401,27 @@ def SPDX(value: str) -> bool:
 
     def SPDX(value: str) -> bool:
         return True
+
+
+VALID_IMPORT_NAME = re.compile(
+    r"""
+    ^                                  # start of string
+        [A-Za-z_][A-Za-z_0-9]+         # a valid Python identifier
+        (?:\.[A-Za-z_][A-Za-z_0-9]*)*  # optionally followed by .identifier's
+    (?:\s*;\s*private)?                # optionally followed by ; private
+    $                                  # end of string
+    """,
+    re.VERBOSE,
+)
+
+
+def import_name(value: str) -> bool:
+    """This is a valid import name. It has to be series of python identifiers
+    (not keywords), separated by dots, optionally followed by a semicolon and
+    the keyword "private".
+    """
+    if VALID_IMPORT_NAME.match(value) is None:
+        return False
+
+    idents, _, _ = value.partition(";")
+    return all(not keyword.iskeyword(ident) for ident in idents.rstrip().split("."))

src/validate_pyproject/project_metadata.schema.json

@@ -237,14 +237,16 @@
       "description": "Lists import names which a project, when installed, would exclusively provide.",
       "type": "array",
       "items": {
-        "type": "string"
+        "type": "string",
+        "format": "import-name"
       }
     },
     "import-namespaces": {
       "description": "Lists import names that, when installed, would be provided by the project, but not exclusively.",
       "type": "array",
       "items": {
-        "type": "string"
+        "type": "string",
+        "format": "import-name"
       }
     },
     "dynamic": {

tests/test_formats.py

@@ -455,3 +455,16 @@ def _failed_download():
 def test_private_classifier():
     assert formats.trove_classifier("private :: Keep Off PyPI") is True
     assert formats.trove_classifier("private:: Keep Off PyPI") is False
+
+
+def test_import_name():
+    assert formats.import_name("simple")
+    assert formats.import_name("some1; private")
+    assert formats.import_name("other.thing ; private")
+    assert formats.import_name("_other._thing ; private")
+
+    assert not formats.import_name("one two")
+    assert not formats.import_name("one; two")
+    assert not formats.import_name("1thing")
+    assert not formats.import_name("for")
+    assert not formats.import_name("thing.is.keyword")