Performance update

[afischerdev]

Reminder:
As suggested in #835 the performance could be increase with using androidx-collections.

replace
btool.util.CompactLongMap
with
androidx.collection.MutableLongObjectMap

We should check if the AndroidX classes work with pure Java. Or if there are pure Java equivalents.

[devemux86]

We should check if the AndroidX classes work with pure Java. Or if there are pure Java equivalents.

@afischerdev 👍

[zod]

Wouldn't this add a dependency to android libraries to the brouter core?

[afischerdev]

@zod
Yes, let us see if we find an other way outside Android.
May be eclipse-collections UnifiyMap is our friend.

[jgillich]

androidx-collection doesn't require Android and it's light on dependencies. Also there are Java docs for it, so I assume it works fine in a Java project.

[devemux86]

@afischerdev

Better to try the native Java collections first
and then see if there is really a need or verified performance improvement from third-party libraries.

[afischerdev]

@jgillich

androidx-collection doesn't require Android and it's light on dependencies. Also there are Java docs for it, so I assume it works fine in a Java project.

Hmm, my little test says no. I would it define like this:

import androidx.collection.MutableLongObjectMap;

public class MapTest {

  public static void main( final java.lang.String[] args ) {
    MapTest mt = new MapTest();
    mt.mapTest(10);
  }

  public void mapTest(int n)  {
    MutableLongObjectMap<String> list = new MutableLongObjectMap(n);
  }
}

With a compiler call

javac -cp ./;./collection-1.5.0.jar MapTest.java

When I have a look into the jar, I also didn't find this class. Download jar from Maven.

[jgillich]

Native collections are faster as well, but they use much more memory due to boxing. See my tests

@afischerdev You need collection-jvm

androidx/collection/MutableLongObjectMap.class  

[afischerdev]

@jgillich
Great, that works, it can be compiled. But not run with a small addon.

MutableLongObjectMap<String> list = new MutableLongObjectMap(0);
list.put((long)n, "s"+n);

Comes back with

Exception in thread "main" java.lang.NoClassDefFoundError: kotlin/collections/ArraysKt

Seems to require more dependencies.

[afischerdev]

Here are some results:

HashMap 1000 45.1468ms
HashMap 10000 6.0109ms
HashMap 100000 24.0755ms

CompactLongMap 1000 27.043ms
CompactLongMap 10000 7.2372ms
CompactLongMap 100000 84.4636ms

CompactLongMap fast 1000 1.4364ms
CompactLongMap fast 10000 6.8276ms
CompactLongMap fast 100000 53.0298ms

MutableMap no contains(1000000) 1000 479.1641ms
MutableMap no contains(1000000) 10000 9.6114ms
MutableMap no contains(1000000) 100000 18.8523ms

UnifiedMap no contains(1000000) 1000 0.3574ms
UnifiedMap no contains(1000000) 10000 1.3213ms
UnifiedMap no contains(1000000) 100000 12.7431ms

Tests fill a map, then test contains and get the value.
MutableMap and UnifiedMap are from the eclipse-collections. They break on the 1.000.000 test, so this times are without contains.