asm: fix trace logging of XMM registers (bytecodealliance#10538)

* asm: fix trace logging of XMM registers

Along the lines of bytecodealliance#10389 and bytecodealliance#10478, this change fixes the case where
an XMM register is pretty-printed during logging, which may happen
before register allocation has provided a true HW register.

Fixes bytecodealliance#10529.

* Run filetests with logging enabled

Author: abrown

cranelift/assembler-x64/src/xmm.rs

@@ -25,8 +25,8 @@ impl<R: AsReg> Xmm<R> {
     }
 
     /// Return the register name.
-    pub fn to_string(&self) -> &str {
-        enc::to_string(self.enc())
+    pub fn to_string(&self) -> String {
+        self.0.to_string(None)
     }
 }
 

cranelift/tests/logged-filetests.rs

@@ -0,0 +1,21 @@
+/// This test runs the filetests with logging enabled.
+///
+/// In order to avoid issues like [#10529] and similar, we re-run the filetests
+/// with logging enabled. This pretty-prints instructions prior to register
+/// allocation, when they may not have real HW registers assigned. Ideally this
+/// test is temporary while we work out details in the `cranelift-assembler-x64`
+/// crate (TODO).
+///
+/// [#10529]: https://github.com/bytecodealliance/wasmtime/issues/10529
+#[test]
+fn logged_filetests() -> anyhow::Result<()> {
+    let _ = pretty_env_logger::formatted_builder()
+        .filter_module(
+            "cranelift_codegen::machinst::lower",
+            log::LevelFilter::Trace,
+        )
+        .is_test(true)
+        .init();
+    cranelift_filetests::run(false, false, &["filetests".into(), "docs".into()])?;
+    Ok(())
+}