Skip to content

Commit 492fccd

Browse files
ezbrcopybara-github
authored andcommitted
Skip flaky expectations in waiter_test for MSVC.
PiperOrigin-RevId: 782040454 Change-Id: Ia51834a4c871b6bbf4748805656b7e68169239d6
1 parent 415dccb commit 492fccd

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

absl/synchronization/internal/waiter_test.cc

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,10 @@ TYPED_TEST_P(WaiterTest, WaitTimeWoken) {
129129
start + absl::Seconds(10))));
130130
absl::Duration waited = absl::Now() - start;
131131
EXPECT_GE(waited, WithTolerance(absl::Milliseconds(500)));
132-
EXPECT_LT(waited, absl::Seconds(2));
132+
#ifndef _MSC_VER
133+
// Skip on MSVC due to flakiness.
134+
EXPECT_LT(waited, absl::Seconds(2));
135+
#endif
133136
}
134137

135138
TYPED_TEST_P(WaiterTest, WaitDurationReached) {
@@ -139,7 +142,10 @@ TYPED_TEST_P(WaiterTest, WaitDurationReached) {
139142
absl::synchronization_internal::KernelTimeout(absl::Milliseconds(500))));
140143
absl::Duration waited = absl::Now() - start;
141144
EXPECT_GE(waited, WithTolerance(absl::Milliseconds(500)));
142-
EXPECT_LT(waited, absl::Seconds(1));
145+
#ifndef _MSC_VER
146+
// Skip on MSVC due to flakiness.
147+
EXPECT_LT(waited, absl::Seconds(1));
148+
#endif
143149
}
144150

145151
TYPED_TEST_P(WaiterTest, WaitTimeReached) {
@@ -149,7 +155,10 @@ TYPED_TEST_P(WaiterTest, WaitTimeReached) {
149155
start + absl::Milliseconds(500))));
150156
absl::Duration waited = absl::Now() - start;
151157
EXPECT_GE(waited, WithTolerance(absl::Milliseconds(500)));
152-
EXPECT_LT(waited, absl::Seconds(1));
158+
#ifndef _MSC_VER
159+
// Skip on MSVC due to flakiness.
160+
EXPECT_LT(waited, absl::Seconds(1));
161+
#endif
153162
}
154163

155164
REGISTER_TYPED_TEST_SUITE_P(WaiterTest,

0 commit comments

Comments
 (0)