Skip to content

Commit 6725fe3

Browse files
ezbrcopybara-github
authored andcommitted
Skip the ShortStringCollision test on WASM.
We see collisions due to no ASLR and 32-bit size_t. PiperOrigin-RevId: 820276001 Change-Id: I6f3e0d8ade2152fed9759285b7f92a133c6bff14
1 parent ef1ae8e commit 6725fe3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

absl/hash/BUILD.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ cc_test(
8686
],
8787
copts = ABSL_TEST_COPTS,
8888
linkopts = ABSL_DEFAULT_LINKOPTS,
89-
tags = [
90-
"no_test_wasm", # b/452379654
91-
],
9289
deps = [
9390
":hash",
9491
":hash_testing",

absl/hash/hash_test.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1242,6 +1242,9 @@ TEST(HashOf, DoubleSignCollision) {
12421242

12431243
// Test for collisions in short strings if PrecombineLengthMix is low quality.
12441244
TEST(PrecombineLengthMix, ShortStringCollision) {
1245+
#if defined(__wasm__)
1246+
GTEST_SKIP() << "Fails flakily on wasm due to no ASLR and 32-bit size_t.";
1247+
#endif
12451248
std::string s1 = "00";
12461249
std::string s2 = "000";
12471250
constexpr char kMinChar = 0;

0 commit comments

Comments
 (0)