Skip to content

Commit 6dee153

Browse files
Royna2544copybara-github
authored andcommitted
PR #1707: Fixup absl_random compile breakage in Apple ARM64 targets
Imported from GitHub PR #1707 Switched to append a full string of "-Xarch_x86_64 -maes" instead of " -Xarch_x86_64" "-maes", for example. Now cmake correctly appends -Xarch_x86_64 to each x64 specific compile option, removing the error caused in recent clang releases: clang++: error: unsupported option '-msse4.1' for target 'arm64-apple-darwin23.5.0' Merge 83d1753 into f46495e Merging this change closes #1707 COPYBARA_INTEGRATE_REVIEW=#1707 from Royna2544:patch-1 83d1753 PiperOrigin-RevId: 651046496 Change-Id: Ifdb3848febeead4fb562a2d9f0fdca2e0aea185d
1 parent f46495e commit 6dee153

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

absl/copts/AbseilConfigureCopts.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ if(APPLE AND CMAKE_CXX_COMPILER_ID MATCHES [[Clang]])
4242
string(TOUPPER "${_arch}" _arch_uppercase)
4343
string(REPLACE "X86_64" "X64" _arch_uppercase ${_arch_uppercase})
4444
foreach(_flag IN LISTS ABSL_RANDOM_HWAES_${_arch_uppercase}_FLAGS)
45-
list(APPEND ABSL_RANDOM_RANDEN_COPTS "-Xarch_${_arch}" "${_flag}")
45+
list(APPEND ABSL_RANDOM_RANDEN_COPTS "-Xarch_${_arch} ${_flag}")
4646
endforeach()
4747
endforeach()
4848
# If a compiler happens to deal with an argument for a currently unused

0 commit comments

Comments
 (0)