Move default case to statement outside switch block in log_severity.h.

zetafunction · copybara-github · commit a00f6d6d0ce5 · 2024-01-11T09:57:58.000-08:00
Some compilers warn if a switch block that already covers all
enumeration values also has a default label.

PiperOrigin-RevId: 597583941
Change-Id: Ib3eb08dca0a19105522c61e47944cfc75280c15e
diff --git a/absl/base/log_severity.h b/absl/base/log_severity.h
@@ -104,8 +104,8 @@ constexpr const char* LogSeverityName(absl::LogSeverity s) {
     case absl::LogSeverity::kWarning: return "WARNING";
     case absl::LogSeverity::kError: return "ERROR";
     case absl::LogSeverity::kFatal: return "FATAL";
-    default: return "UNKNOWN";
   }
+  return "UNKNOWN";
 }
 
 // NormalizeLogSeverity()

Original file line number	Diff line number	Diff line change
`@@ -104,8 +104,8 @@ constexpr const char* LogSeverityName(absl::LogSeverity s) {`
`104`	`104`	`case absl::LogSeverity::kWarning: return "WARNING";`
`105`	`105`	`case absl::LogSeverity::kError: return "ERROR";`
`106`	`106`	`case absl::LogSeverity::kFatal: return "FATAL";`
`107`		`- default: return "UNKNOWN";`
`108`	`107`	`}`
	`108`	`+ return "UNKNOWN";`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`// NormalizeLogSeverity()`