PR #1695: Fix time library build for Apple platforms

EduMenges · copybara-github · commit db1255ca30db · 2024-07-11T08:18:50.000-07:00
Imported from GitHub PR #1695 #1495 converted the `if (APPLE)` check for linking against `CoreFoundation` to generator expressions, which is fine and all. The issue is that they forgot the other Apple platforms, making builds for iOS impossible. This patch fixes this issue by adding the other Apple platforms that CMake support to the generator expression. Merge 4f01df8 into 6dee153 Merging this change closes #1695 COPYBARA_INTEGRATE_REVIEW=#1695 from GeniusVentures:fix-time-build 4f01df8 PiperOrigin-RevId: 651416278 Change-Id: I47e4d52384e946cc9e421922f7c6edd5bfa1d976
diff --git a/absl/time/CMakeLists.txt b/absl/time/CMakeLists.txt
@@ -83,7 +83,7 @@ absl_cc_library(
     Threads::Threads
     # TODO(#1495): Use $<LINK_LIBRARY:FRAMEWORK,CoreFoundation> once our
     # minimum CMake version >= 3.24
-    $<$<PLATFORM_ID:Darwin>:-Wl,-framework,CoreFoundation>
+    $<$<PLATFORM_ID:Darwin,iOS,tvOS,visionOS,watchOS>:-Wl,-framework,CoreFoundation>
 )
 
 # Internal-only target, do not depend on directly.

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ absl_cc_library(`
`83`	`83`	`Threads::Threads`
`84`	`84`	`# TODO(#1495): Use $<LINK_LIBRARY:FRAMEWORK,CoreFoundation> once our`
`85`	`85`	`# minimum CMake version >= 3.24`
`86`		`- $<$<PLATFORM_ID:Darwin>:-Wl,-framework,CoreFoundation>`
	`86`	`+ $<$<PLATFORM_ID:Darwin,iOS,tvOS,visionOS,watchOS>:-Wl,-framework,CoreFoundation>`
`87`	`87`	`)`
`88`	`88`
`89`	`89`	`# Internal-only target, do not depend on directly.`