Skip to content

Commit f76c21f

Browse files
ezbrcopybara-github
authored andcommitted
Remove unused NonIterableBitMask::HighestBitSet function.
PiperOrigin-RevId: 781886211 Change-Id: Ia2bba19bfe8975c7a22148e043310df726465a5c
1 parent 118924e commit f76c21f

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

absl/container/internal/hashtable_control_bytes.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,6 @@ class NonIterableBitMask {
9191
return container_internal::TrailingZeros(mask_) >> Shift;
9292
}
9393

94-
// Returns the index of the highest *abstract* bit set in `self`.
95-
uint32_t HighestBitSet() const {
96-
return static_cast<uint32_t>((bit_width(mask_) - 1) >> Shift);
97-
}
98-
9994
// Returns the number of trailing zero *abstract* bits.
10095
uint32_t TrailingZeros() const {
10196
return container_internal::TrailingZeros(mask_) >> Shift;

absl/container/internal/hashtable_control_bytes_test.cc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,11 @@ TYPED_TEST(GroupTest, MaskEmpty) {
165165
CtrlT(7), CtrlT(5), CtrlT(3), CtrlT(1),
166166
CtrlT(1), CtrlT(1), CtrlT(1), CtrlT(1)};
167167
EXPECT_THAT(GroupType{group}.MaskEmpty().LowestBitSet(), 0);
168-
EXPECT_THAT(GroupType{group}.MaskEmpty().HighestBitSet(), 4);
169168
} else if (GroupType::kWidth == 8) {
170169
ctrl_t group[] = {ctrl_t::kEmpty, CtrlT(1), CtrlT(2),
171170
ctrl_t::kDeleted, CtrlT(2), CtrlT(1),
172171
ctrl_t::kSentinel, CtrlT(1)};
173172
EXPECT_THAT(GroupType{group}.MaskEmpty().LowestBitSet(), 0);
174-
EXPECT_THAT(GroupType{group}.MaskEmpty().HighestBitSet(), 0);
175173
} else {
176174
FAIL() << "No test coverage for Group::kWidth==" << GroupType::kWidth;
177175
}
@@ -225,13 +223,11 @@ TYPED_TEST(GroupTest, MaskEmptyOrDeleted) {
225223
CtrlT(7), CtrlT(5), CtrlT(3), CtrlT(1),
226224
CtrlT(1), CtrlT(1), CtrlT(1), CtrlT(1)};
227225
EXPECT_THAT(GroupType{group}.MaskEmptyOrDeleted().LowestBitSet(), 0);
228-
EXPECT_THAT(GroupType{group}.MaskEmptyOrDeleted().HighestBitSet(), 4);
229226
} else if (GroupType::kWidth == 8) {
230227
ctrl_t group[] = {ctrl_t::kEmpty, CtrlT(1), CtrlT(2),
231228
ctrl_t::kDeleted, CtrlT(2), CtrlT(1),
232229
ctrl_t::kSentinel, CtrlT(1)};
233230
EXPECT_THAT(GroupType{group}.MaskEmptyOrDeleted().LowestBitSet(), 0);
234-
EXPECT_THAT(GroupType{group}.MaskEmptyOrDeleted().HighestBitSet(), 3);
235231
} else {
236232
FAIL() << "No test coverage for Group::kWidth==" << GroupType::kWidth;
237233
}
@@ -247,13 +243,11 @@ TYPED_TEST(GroupTest, MaskFullOrSentinel) {
247243
ctrl_t::kEmpty, ctrl_t::kDeleted, ctrl_t::kDeleted, ctrl_t::kDeleted,
248244
};
249245
EXPECT_THAT(GroupType{group}.MaskFullOrSentinel().LowestBitSet(), 3);
250-
EXPECT_THAT(GroupType{group}.MaskFullOrSentinel().HighestBitSet(), 6);
251246
} else if (GroupType::kWidth == 8) {
252247
ctrl_t group[] = {ctrl_t::kEmpty, ctrl_t::kDeleted, CtrlT(2),
253248
ctrl_t::kDeleted, CtrlT(2), ctrl_t::kSentinel,
254249
ctrl_t::kDeleted, ctrl_t::kEmpty};
255250
EXPECT_THAT(GroupType{group}.MaskFullOrSentinel().LowestBitSet(), 2);
256-
EXPECT_THAT(GroupType{group}.MaskFullOrSentinel().HighestBitSet(), 5);
257251
} else {
258252
FAIL() << "No test coverage for Group::kWidth==" << GroupType::kWidth;
259253
}

0 commit comments

Comments
 (0)