abseil logging / glog migration: log-levels

[sschnug]

Hi,

i'm trying to see a possible migration path of Glog to abseil-cpps logging-module and are struggling a bit in regards to log-levels.

Having heavily relied on VLOG(some_integer) in the past, i can't see a way to continue with this approach seeing abseil-cpps log-severities (https://github.com/abseil/abseil-cpp/blob/master/absl/base/log_severity.h) because of the cardinality of predefined levels of the latter.

While having a small set of log-levels is probably a good idea in general and popular among various logging-libraries (e.g. spdlog https://github.com/gabime/spdlog/blob/4f800773393d3ebac13c1fcd946a315d4d72bcd9/include/spdlog/common.h#L211), i only see 3 levels (and a 4th with special semantics).

I'm personally kind of missing DEBUG and maybe TRACE levels (if we stay in predefined-level world).
abseil-py surprisingly has support for DEBUG (https://abseil.io/docs/python/guides/logging).

Having well-supported access to integer-based log-levels would even be better.

or-tools, somewhat reflecting my use-cases (library-code with easy to brake combinatorial-stuff in very deep hierarchies) uses 6 different log-levels too (according to a quick look: https://github.com/google/or-tools/search?q=vlog , link seems to automatically die, but it's a simple search for VLOG).

Maybe this has something to do with abseil-cpp focusing on service-code and less on library-code?

Is there any oversight on my end or are there any tips on achieving a more fine-granular log-control?

(it seems one could introduce negative levels > kNegativeInfinity, but i'm not sure about the effects of NormalizeLogSeverity and it also feels wrong)

Thanks for reading!

[derekmauro]

We are working on releasing VLOG. Please be patient.

[derekmauro]

I get that and I'm not happy about it either. We did just release DFATAL after the release was cut. There is still no ETA, but we are a bit closer.

[jiawen]

No pressure! I'm happy to help in any way I can (testing on funny platforms, etc).

[derekmauro]

I got so frustrated with the lack of progress on this that I went and pushed it though myself. Please test out 7b6c17e and let us know if you encounter any issues.

[sfc-gh-ebrossard]

Awesome, thanks so much! It's like an early Christmas present 😀 I'll try to plug in Abseil's logging soon for our team's current glog usage and see how it goes.

By the way, I'm not sure how much it matters, but there's a Buganizer link and a reference to TAP in the commit above.

[derekmauro]

No problem!

With regards to the buganizer link: At one point we redacted the buganizer links but we are now ok publishing them. Differences between our internal repo and what makes it to GitHub just make it harder to sync code.

[sschnug]

I guess this can be closed now as the feature is now available. Thanks!