Consistent pluralisation of 'continuations'

Author: bernardd

.tool-versions

@@ -1,2 +1,2 @@
-elixir 1.13.3
+elixir 1.13.4
 erlang 24.2.1

lib/absinthe/phoenix/channel.ex

@@ -141,13 +141,13 @@ defmodule Absinthe.Phoenix.Channel do
 
         {{:ok, %{subscriptionId: topic}}, socket}
 
-      {:more, %{"subscribed" => topic}, continuation, context} ->
+      {:more, %{"subscribed" => topic}, continuations, context} ->
         reply(socket_ref(socket), {:ok, %{subscriptionId: topic}})
 
         pubsub_subscribe(topic, socket)
         socket = Absinthe.Phoenix.Socket.put_options(socket, context: context)
 
-        handle_subscription_continuation(continuation, topic, socket)
+        handle_subscription_continuation(continuations, topic, socket)
 
         {:noreply, socket}
 
@@ -159,13 +159,13 @@ defmodule Absinthe.Phoenix.Channel do
         socket = Absinthe.Phoenix.Socket.put_options(socket, context: context)
         {{:error, reply}, socket}
 
-      {:more, %{data: _} = reply, continuation, context} ->
+      {:more, %{data: _} = reply, continuations, context} ->
         id = new_query_id()
 
         socket =
           socket
           |> Absinthe.Phoenix.Socket.put_options(context: context)
-          |> handle_continuation(continuation, id)
+          |> handle_continuation(continuations, id)
 
         {{:ok, add_query_id(reply, id)}, socket}
 
@@ -178,8 +178,8 @@ defmodule Absinthe.Phoenix.Channel do
     {module, fun} = pipeline
 
     case Absinthe.Pipeline.run(document, apply(module, fun, [schema, options])) do
-      {:ok, %{result: %{continuation: continuation} = result, execution: res}, _phases} ->
-        {:more, Map.delete(result, :continuation), continuation, res.context}
+      {:ok, %{result: %{continuations: continuations} = result, execution: res}, _phases} ->
+        {:more, Map.delete(result, :continuations), continuations, res.context}
 
       {:ok, %{result: result, execution: res}, _phases} ->
         {:ok, result, res.context}
@@ -215,16 +215,16 @@ defmodule Absinthe.Phoenix.Channel do
     |> Absinthe.Pipeline.for_document(options)
   end
 
-  defp handle_continuation(socket, continuation, id) do
-    case Absinthe.Pipeline.continue(continuation) do
-      {:ok, %{result: %{continuation: next_continuation} = result}, _phases} ->
+  defp handle_continuation(socket, continuations, id) do
+    case Absinthe.Pipeline.continue(continuations) do
+      {:ok, %{result: %{continuation: next_continuations} = result}, _phases} ->
         result =
           result
-          |> Map.delete(:continuation)
+          |> Map.delete(:continuations)
           |> add_query_id(id)
 
         push(socket, "doc", result)
-        handle_continuation(socket, next_continuation, id)
+        handle_continuation(socket, next_continuations, id)
 
       {:ok, %{result: result}, _phases} ->
         push(socket, "doc", add_query_id(result, id))
@@ -245,15 +245,15 @@ defmodule Absinthe.Phoenix.Channel do
 
   defp add_query_id(result, id), do: Map.put(result, :queryId, id)
 
-  defp handle_subscription_continuation(continuation, topic, socket) do
-    case Absinthe.Pipeline.continue(continuation) do
+  defp handle_subscription_continuation(continuations, topic, socket) do
+    case Absinthe.Pipeline.continue(continuations) do
       {:ok, %{result: :no_more_results}, _phases} ->
         :ok
 
       {:ok, %{result: result}, _phases} ->
         socket = push_subscription_item(result.data, topic, socket)
 
-        case result[:continuation] do
+        case result[:continuations] do
           nil -> :ok
           c -> handle_subscription_continuation(c, topic, socket)
         end

mix.lock

@@ -1,5 +1,5 @@
 %{
-  "absinthe": {:git, "https://github.com/circles-learning-labs/absinthe.git", "27441d036539124461430c9ca2b888f7301a9a9e", [branch: "subscription-prime"]},
+  "absinthe": {:git, "https://github.com/circles-learning-labs/absinthe.git", "b0cd04ede7fe4b1e1ab9f177106d28a3c4d84a63", [branch: "subscription-prime"]},
   "absinthe_plug": {:hex, :absinthe_plug, "1.5.0", "018ef544cf577339018d1f482404b4bed762e1b530c78be9de4bbb88a6f3a805", [:mix], [{:absinthe, "~> 1.5.0", [hex: :absinthe, repo: "hexpm", optional: false]}, {:plug, "~> 1.3.2 or ~> 1.4", [hex: :plug, repo: "hexpm", optional: false]}], "hexpm", "4c160f4ce9a1233a4219a42de946e4e05d0e8733537cd5d8d20e7d4ef8d4b7c7"},
   "decimal": {:hex, :decimal, "2.0.0", "a78296e617b0f5dd4c6caf57c714431347912ffb1d0842e998e9792b5642d697", [:mix], [], "hexpm", "34666e9c55dea81013e77d9d87370fe6cb6291d1ef32f46a1600230b1d44f577"},
   "earmark": {:hex, :earmark, "1.4.4", "4821b8d05cda507189d51f2caeef370cf1e18ca5d7dfb7d31e9cafe6688106a4", [:mix], [], "hexpm", "1f93aba7340574847c0f609da787f0d79efcab51b044bb6e242cae5aca9d264d"},