Skip to content

Commit a48cbc5

Browse files
committed
Address comments
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
1 parent 452a2c3 commit a48cbc5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

domains/service.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ func (svc service) CreateDomain(ctx context.Context, session authn.Session, d Do
6363

6464
d.CreatedAt = time.Now().UTC()
6565

66+
// Domain is created in repo first, because Roles table have foreign key relation with Domain ID
6667
dom, err := svc.repo.SaveDomain(ctx, d)
6768
if err != nil {
6869
return Domain{}, []roles.RoleProvision{}, errors.Wrap(svcerr.ErrCreateEntity, err)
@@ -156,6 +157,7 @@ func (svc service) DisableDomain(ctx context.Context, session authn.Session, id
156157
return dom, nil
157158
}
158159

160+
// Only SuperAdmin can freeze the domain.
159161
func (svc service) FreezeDomain(ctx context.Context, session authn.Session, id string) (Domain, error) {
160162
status := FreezeStatus
161163
updatedAt := time.Now().UTC()
@@ -339,6 +341,7 @@ func (svc *service) DeleteInvitation(ctx context.Context, session authn.Session,
339341
return nil
340342
}
341343

344+
// Add addition removal of user from invitations.
342345
func (svc *service) RemoveEntityMembers(ctx context.Context, session authn.Session, entityID string, members []string) error {
343346
for _, member := range members {
344347
if err := svc.repo.DeleteInvitation(ctx, member, entityID); err != nil && err != repoerr.ErrNotFound {

0 commit comments

Comments
 (0)