replace hardcoded admin checks with builtInRoles map lookup

Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

Author: JeffMboya

pkg/roles/provisionmanage.go

@@ -559,13 +559,13 @@ func (r ProvisionManageService) RoleRemoveMembers(ctx context.Context, session a
 		return errors.Wrap(svcerr.ErrRemoveEntity, err)
 	}
 
-	if ro.Name == "admin" {
+	if _, ok := r.builtInRoles[BuiltInRoleName(ro.Name)]; ok {
 		page, err := r.repo.RoleListMembers(ctx, ro.ID, 0, 0)
 		if err != nil {
 			return errors.Wrap(svcerr.ErrViewEntity, err)
 		}
 		if page.Total <= uint64(len(members)) {
-			return errors.Wrap(svcerr.ErrRemoveEntity, fmt.Errorf("admin role must retain at least one member"))
+			return errors.Wrap(svcerr.ErrRemoveEntity, fmt.Errorf("built-in role '%s' must retain at least one member", ro.Name))
 		}
 	}
 
@@ -602,8 +602,8 @@ func (r ProvisionManageService) RoleRemoveAllMembers(ctx context.Context, sessio
 		return errors.Wrap(svcerr.ErrRemoveEntity, err)
 	}
 
-	if ro.Name == "admin" {
-		return errors.Wrap(svcerr.ErrRemoveEntity, fmt.Errorf("removing all members from the built-in admin role is not permitted"))
+	if _, ok := r.builtInRoles[BuiltInRoleName(ro.Name)]; ok {
+		return errors.Wrap(svcerr.ErrRemoveEntity, fmt.Errorf("removing all members from built-in role '%s' is not permitted", ro.Name))
 	}
 
 	prs := policies.Policy{