Fix jmx2dsl conversion when empty header is specified

rabelenda-abstracta · rabelenda-abstracta · commit 3b9dfb621a3f · 2022-08-17T14:51:32.000-03:00
diff --git a/jmeter-java-dsl/src/main/java/us/abstracta/jmeter/javadsl/codegeneration/params/StringParam.java b/jmeter-java-dsl/src/main/java/us/abstracta/jmeter/javadsl/codegeneration/params/StringParam.java
@@ -20,7 +20,7 @@ public StringParam(String value) {
 
   @Override
   public String buildCode(String indent) {
-    return buildStringLiteral(value, indent);
+    return buildStringLiteral(value == null ? "" : value, indent);
   }
 
 }
diff --git a/jmeter-java-dsl/src/test/java/us/abstracta/jmeter/javadsl/http/HttpHeadersTest.java b/jmeter-java-dsl/src/test/java/us/abstracta/jmeter/javadsl/http/HttpHeadersTest.java
@@ -19,6 +19,7 @@ public DslTestPlan testPlanWithHeaders() {
               httpHeaders()
                   .header("Accept", "application/json")
                   .header("X-My-Header", "my-value")
+                  .header("X-Other-Header", "")
                   .contentType(ContentType.APPLICATION_JSON),
               httpSampler("http://localhost")
           )

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public StringParam(String value) {`
`20`	`20`
`21`	`21`	`@Override`
`22`	`22`	`public String buildCode(String indent) {`
`23`		`- return buildStringLiteral(value, indent);`
	`23`	`+ return buildStringLiteral(value == null ? "" : value, indent);`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ public DslTestPlan testPlanWithHeaders() {`
`19`	`19`	`httpHeaders()`
`20`	`20`	`.header("Accept", "application/json")`
`21`	`21`	`.header("X-My-Header", "my-value")`
	`22`	`+ .header("X-Other-Header", "")`
`22`	`23`	`.contentType(ContentType.APPLICATION_JSON),`
`23`	`24`	`httpSampler("http://localhost")`
`24`	`25`	`)`