Skip to content

Commit 4e6fd57

Browse files
Fix HTTP Defaults showInGui due to missing arguments property setting
1 parent b66a650 commit 4e6fd57

File tree

4 files changed

+32
-1
lines changed

4 files changed

+32
-1
lines changed

jmeter-java-dsl/src/main/java/us/abstracta/jmeter/javadsl/http/DslHttpDefaults.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33
import java.lang.reflect.Method;
44
import java.nio.charset.Charset;
55
import java.util.List;
6+
import org.apache.jmeter.config.Arguments;
67
import org.apache.jmeter.config.ConfigTestElement;
78
import org.apache.jmeter.protocol.http.config.gui.HttpDefaultsGui;
89
import org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase;
910
import org.apache.jmeter.testelement.TestElement;
11+
import org.apache.jmeter.testelement.property.TestElementProperty;
1012
import us.abstracta.jmeter.javadsl.codegeneration.MethodCall;
1113
import us.abstracta.jmeter.javadsl.codegeneration.MethodCallContext;
1214
import us.abstracta.jmeter.javadsl.codegeneration.MethodParam;
@@ -239,6 +241,7 @@ protected TestElement buildTestElement() {
239241
if (encoding != null) {
240242
ret.setProperty(HTTPSamplerBase.CONTENT_ENCODING, encoding.toString());
241243
}
244+
ret.setProperty(new TestElementProperty(HTTPSamplerBase.ARGUMENTS, new Arguments()));
242245
if (proxyUrl != null) {
243246
JmeterUrl parsedUrl = JmeterUrl.valueOf(proxyUrl);
244247
ret.setProperty(HTTPSamplerBase.PROXYSCHEME, parsedUrl.protocol());
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
package PACKAGE_NAME;public class PerformanceTest {
2+
}

jmeter-java-dsl/src/test/java/us/abstracta/jmeter/javadsl/core/JmeterDslCoreTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.junit.jupiter.api.io.TempDir;
2727
import us.abstracta.jmeter.javadsl.JmeterDslTest;
2828
import us.abstracta.jmeter.javadsl.core.StringTemplate.StringTemplateAssert;
29-
import us.abstracta.jmeter.javadsl.util.TestResource;
3029

3130
public class JmeterDslCoreTest extends JmeterDslTest {
3231

jmeter-java-dsl/src/test/java/us/abstracta/jmeter/javadsl/http/DslHttpDefaultsTest.java

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,14 @@
1111
import static us.abstracta.jmeter.javadsl.JmeterDsl.testPlan;
1212
import static us.abstracta.jmeter.javadsl.JmeterDsl.threadGroup;
1313

14+
import java.util.concurrent.ExecutorService;
15+
import java.util.concurrent.Executors;
16+
import java.util.concurrent.TimeUnit;
17+
import javax.swing.JFrame;
18+
import org.assertj.swing.core.BasicRobot;
19+
import org.assertj.swing.core.Robot;
20+
import org.assertj.swing.finder.WindowFinder;
21+
import org.assertj.swing.fixture.FrameFixture;
1422
import org.junit.jupiter.api.Test;
1523
import us.abstracta.jmeter.javadsl.JmeterDslTest;
1624

@@ -115,4 +123,23 @@ public void shouldSendRequestThroughProxyWithAuthWhenProxyIsConfiguredInConfigWi
115123
}
116124
}
117125

126+
@Test
127+
public void shouldShowInGuiWhenShowInGui() {
128+
Robot robot = BasicRobot.robotWithNewAwtHierarchy();
129+
ExecutorService executor = Executors.newSingleThreadExecutor();
130+
try {
131+
executor.submit(() -> {
132+
FrameFixture frame = WindowFinder.findFrame(JFrame.class)
133+
.withTimeout(10, TimeUnit.SECONDS)
134+
.using(robot);
135+
frame.requireVisible();
136+
frame.close();
137+
});
138+
httpDefaults().showInGui();
139+
} finally {
140+
executor.shutdownNow();
141+
robot.cleanUp();
142+
}
143+
}
144+
118145
}

0 commit comments

Comments
 (0)