Skip to content

Commit 8a8eb30

Browse files
Use latest selenium version in recorder to avoid issues with latest chrome versions
This change requires changing the required jvm for recorder & jmx2dsl
1 parent 48d8572 commit 8a8eb30

File tree

7 files changed

+25
-4
lines changed

7 files changed

+25
-4
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/setup-java@v3
1515
with:
1616
distribution: temurin
17-
java-version: 8
17+
java-version: 11
1818
cache: maven
1919
- uses: browser-actions/setup-chrome@v1
2020
- name: Run maven tests

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- uses: actions/setup-java@v3
1616
with:
1717
distribution: temurin
18-
java-version: 8
18+
java-version: 11
1919
cache: maven
2020
- uses: actions/setup-node@v3
2121
with:

docs/guide/jmx2dsl.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ public class PerformanceTest {
7676
}
7777
```
7878

79+
::: warning
80+
Unlike the rest of JMeter DSL which is compiled with Java 8, `jmdsl.jar` and `us.abstracta.jmeter:jmeter-java-dsl-cli` are compiled with Java 11 due to some dependencies requirement (latest Selenium drivers mainly).
81+
82+
So, to run above commands, you will need Java 11 or newer.
83+
:::
84+
7985
::: tip
8086
Review and try generated code before executing it as is. I.e: tune thread groups and iterations to 1 to give it a try.
8187
:::

docs/guide/recorder/index.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,12 @@ Use `java -jar jmdsl.jar help recorder` to see the list of options to customize
2222
In general use `---url-includes` to ignore URLs that are not relevant to the performance test.
2323
:::
2424

25+
::: warning
26+
Unlike the rest of JMeter DSL, which is compiled with Java 8, `jmdsl.jar` and `us.abstracta.jmeter:jmeter-java-dsl-cli` are compiled with Java 11 due to some dependencies requirement (latest Selenium drivers mainly).
27+
28+
So, to run above commands, you will need Java 11 or newer.
29+
:::
30+
2531
### Correlations
2632

2733
To avoid fragile test plans with fixed values in request parameters, the DSL recorder, through the usage of the [JMeter Correlation Recorder Plugin](https://github.com/Blazemeter/CorrelationRecorder), allows you to define correlation rules.

jmeter-java-dsl-cli/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@
1717
<properties>
1818
<picocli.version>4.7.1</picocli.version>
1919
<log4j.version>2.19.0</log4j.version>
20+
<!-- Using java 11 since last version of selenium driver with java 8 does not have support for latest version of chrome driver. -->
21+
<maven.compiler.source>11</maven.compiler.source>
22+
<maven.compiler.target>11</maven.compiler.target>
2023
</properties>
2124

2225
<dependencies>

jmeter-java-dsl-recorder/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@
1616
projects (ej: jmeter-java-dsl-cli)
1717
</description>
1818

19+
<properties>
20+
<!-- Using java 11 since last version of selenium driver with java 8 does not have support for latest version of chrome driver. -->
21+
<maven.compiler.source>11</maven.compiler.source>
22+
<maven.compiler.target>11</maven.compiler.target>
23+
</properties>
24+
1925
<dependencies>
2026
<dependency>
2127
<groupId>com.blazemeter</groupId>

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@
5555
<junit-platform.version>1.9.1</junit-platform.version>
5656
<assertj-core.version>3.23.1</assertj-core.version>
5757
<jackson.version>2.14.2</jackson.version>
58-
<!-- This is the last version compatible with java 8. 4.14 requires java 11. -->
59-
<selenium.version>4.13.0</selenium.version>
58+
<selenium.version>4.18.0</selenium.version>
6059
<!-- same version as JMeter dependency -->
6160
<slf4j.version>1.7.36</slf4j.version>
6261
<retrofit.version>2.9.0</retrofit.version>
@@ -174,6 +173,7 @@
174173
<version>3.11.0</version>
175174
<configuration>
176175
<compilerArgs>
176+
<!-- this is to preserve parameters names, mainly for bridge service reflection logic -->
177177
<arg>-parameters</arg>
178178
</compilerArgs>
179179
</configuration>

0 commit comments

Comments
 (0)