Skip to content

Commit 7e7ad1e

Browse files
committed
fix layout of comment replies header to work when avatar image is gone (disabled in content -> image settings)
1 parent 3815f5f commit 7e7ad1e

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

app/src/main/res/layout/comment_replies_header.xml

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,29 +24,30 @@
2424
android:layout_height="wrap_content"
2525
android:layout_marginStart="8dp"
2626
android:layout_marginEnd="8dp"
27+
android:layout_marginTop="16dp"
28+
app:layout_goneMarginStart="16dp"
2729
android:ellipsize="end"
2830
android:lines="1"
2931
android:textAppearance="?android:attr/textAppearanceLarge"
3032
android:textSize="16sp"
3133
app:layout_constraintBottom_toTopOf="@+id/uploadDate"
3234
app:layout_constraintEnd_toStartOf="@+id/thumbsUpImage"
3335
app:layout_constraintStart_toEndOf="@+id/authorAvatar"
34-
app:layout_constraintTop_toTopOf="@+id/authorAvatar"
36+
app:layout_constraintTop_toTopOf="parent"
3537
tools:text="@tools:sample/lorem/random" />
3638

3739
<org.schabi.newpipe.views.NewPipeTextView
3840
android:id="@+id/uploadDate"
3941
android:layout_width="0dp"
4042
android:layout_height="wrap_content"
41-
android:layout_marginStart="8dp"
4243
android:layout_marginEnd="8dp"
4344
android:ellipsize="end"
4445
android:lines="1"
4546
android:textAppearance="?android:attr/textAppearanceSmall"
4647
android:textSize="14sp"
47-
app:layout_constraintBottom_toBottomOf="@+id/authorAvatar"
48+
app:layout_constraintBottom_toBottomOf="@+id/authorName"
4849
app:layout_constraintEnd_toStartOf="@+id/thumbsUpImage"
49-
app:layout_constraintStart_toEndOf="@+id/authorAvatar"
50+
app:layout_constraintStart_toStartOf="@+id/authorName"
5051
app:layout_constraintTop_toBottomOf="@+id/authorName"
5152
tools:text="5 months ago" />
5253

@@ -57,9 +58,9 @@
5758
android:layout_marginEnd="@dimen/video_item_detail_like_margin"
5859
android:contentDescription="@string/detail_likes_img_view_description"
5960
android:src="@drawable/ic_thumb_up"
60-
app:layout_constraintBottom_toBottomOf="@+id/authorAvatar"
61+
app:layout_constraintBottom_toBottomOf="@+id/uploadDate"
6162
app:layout_constraintEnd_toStartOf="@+id/thumbsUpCount"
62-
app:layout_constraintTop_toTopOf="@+id/authorAvatar" />
63+
app:layout_constraintTop_toTopOf="@+id/authorName" />
6364

6465
<org.schabi.newpipe.views.NewPipeTextView
6566
android:id="@+id/thumbsUpCount"
@@ -70,9 +71,9 @@
7071
android:lines="1"
7172
android:textAppearance="?android:attr/textAppearanceMedium"
7273
android:textSize="14sp"
73-
app:layout_constraintBottom_toBottomOf="@+id/authorAvatar"
74+
app:layout_constraintBottom_toBottomOf="@+id/uploadDate"
7475
app:layout_constraintEnd_toStartOf="@+id/heartImage"
75-
app:layout_constraintTop_toTopOf="@+id/authorAvatar"
76+
app:layout_constraintTop_toTopOf="@+id/authorName"
7677
tools:text="12M" />
7778

7879
<ImageView
@@ -82,9 +83,9 @@
8283
android:layout_marginEnd="4dp"
8384
android:contentDescription="@string/detail_heart_img_view_description"
8485
android:src="@drawable/ic_heart"
85-
app:layout_constraintBottom_toBottomOf="@+id/authorAvatar"
86+
app:layout_constraintBottom_toBottomOf="@+id/uploadDate"
8687
app:layout_constraintEnd_toStartOf="@+id/pinnedImage"
87-
app:layout_constraintTop_toTopOf="@+id/authorAvatar"
88+
app:layout_constraintTop_toTopOf="@+id/authorName"
8889
app:layout_goneMarginEnd="16dp" />
8990

9091
<View
@@ -105,9 +106,9 @@
105106
android:layout_marginEnd="16dp"
106107
android:contentDescription="@string/detail_pinned_comment_view_description"
107108
android:src="@drawable/ic_pin"
108-
app:layout_constraintBottom_toBottomOf="@+id/authorAvatar"
109+
app:layout_constraintBottom_toBottomOf="@+id/uploadDate"
109110
app:layout_constraintEnd_toEndOf="parent"
110-
app:layout_constraintTop_toTopOf="@+id/authorAvatar" />
111+
app:layout_constraintTop_toTopOf="@+id/authorName" />
111112

112113
<org.schabi.newpipe.views.NewPipeTextView
113114
android:id="@+id/commentContent"
@@ -120,7 +121,7 @@
120121
android:textSize="14sp"
121122
app:layout_constraintEnd_toEndOf="parent"
122123
app:layout_constraintStart_toStartOf="parent"
123-
app:layout_constraintTop_toBottomOf="@+id/authorAvatar"
124+
app:layout_constraintTop_toBottomOf="@+id/uploadDate"
124125
tools:text="@tools:sample/lorem/random[10]" />
125126

126127
<View

0 commit comments

Comments
 (0)