Merge pull request #63 from kevinvenclovas/main

Optimize some code

Author: abuzuhri

Source/FikaAmazonAPI/AmazonSpApiSDK/Models/Exceptions/AmazonException.cs

@@ -20,9 +20,17 @@ public AmazonException(string msg, IRestResponse response = null) : base(msg)
 
     }
 
-    public class NotFoundException : AmazonException
+    public class AmazonNotFoundException : AmazonException
     {
-        public NotFoundException(string msg, IRestResponse response = null) : base(msg, response)
+        public AmazonNotFoundException(string msg, IRestResponse response = null) : base(msg, response)
+        {
+
+        }
+    }
+
+    public class AmazonUnauthorizedException : AmazonException
+    {
+        public AmazonUnauthorizedException(string msg, IRestResponse response = null) : base(msg, response)
         {
 
         }

Source/FikaAmazonAPI/Services/FeedService.cs

@@ -126,7 +126,7 @@ public CreateFeedDocumentResult CreateFeedDocument(ContentType contentType)
         /// <param name="xml"></param>
         /// <param name="feedType"></param>
         /// <returns></returns>
-        public string SubmitFeed(string xml, FeedType feedType, FeedOptions feedOptions = null)
+        public string SubmitFeed(string xml, FeedType feedType, List<string> marketPlaceIds = null, FeedOptions feedOptions = null)
         {
 
             //FIrst Step get doc
@@ -139,7 +139,7 @@ public string SubmitFeed(string xml, FeedType feedType, FeedOptions feedOptions
             {
                 FeedType = feedType.ToString(),
                 InputFeedDocumentId = feedCreate.FeedDocumentId,
-                MarketplaceIds = new List<string> { MarketPlace.ID },
+                MarketplaceIds = marketPlaceIds ?? new List<string> { MarketPlace.ID },
                 FeedOptions = feedOptions
             };
 
@@ -148,6 +148,8 @@ public string SubmitFeed(string xml, FeedType feedType, FeedOptions feedOptions
 
             return feed.FeedId;
         }
+
+
         private static Stream GetStreamFromUrl(string url)
         {
             byte[] imageData = null;

Source/FikaAmazonAPI/Services/RequestService.cs

@@ -158,13 +158,18 @@ protected void ParseResponse(IRestResponse response)
             if (response.StatusCode == HttpStatusCode.OK || response.StatusCode == HttpStatusCode.Accepted || response.StatusCode == HttpStatusCode.Created)
                 return;
             if (response.StatusCode == HttpStatusCode.NotFound)
-                throw new NotFoundException("Resource that you are looking for is not found", response);
-            else
+                throw new AmazonNotFoundException("Resource that you are looking for is not found", response);
+            if (response.StatusCode == HttpStatusCode.Forbidden)
             {
-                Console.WriteLine("Amazon Api didn't respond with Okay, see exception for more details"+ response.Content);
-                throw new AmazonException("Amazon Api didn't respond with Okay, see exception for more details", response);
+                var error = response.Content.ConvertToErrorResponse();
+                if (error != null && error.Errors.Any(x => x.Code == HttpStatusCode.Unauthorized))
+                {
+                    throw new AmazonUnauthorizedException("Access to requested resource is denied.", response);
+                }
             }
-                
+            
+            Console.WriteLine("Amazon Api didn't respond with Okay, see exception for more details" + response.Content);
+            throw new AmazonException("Amazon Api didn't respond with Okay, see exception for more details", response);
         }
 
         protected void AddQueryParameters(List<KeyValuePair<string, string>> queryParameters)

Source/FikaAmazonAPI/Utils/ErrorResponseHelper.cs

@@ -0,0 +1,40 @@
+using Newtonsoft.Json;
+using System;
+using System.Net;
+
+namespace FikaAmazonAPI.Utils
+{
+    public static class ErrorResponseHelper
+    {
+        public static ErrorResponse ConvertToErrorResponse(this string response)
+        {
+            if (String.IsNullOrEmpty(response)) return null;
+
+            try
+            {
+                return JsonConvert.DeserializeObject<ErrorResponse>(response);
+            }
+            catch
+            {
+                return null;
+            }
+        }
+    }
+
+
+    public class ErrorResponse
+    {
+        [JsonProperty("errors")]
+        public ErrorResponseElement[] Errors;
+    }
+
+    public class ErrorResponseElement
+    {
+        [JsonProperty("message")]
+        public string Message { get; set; }
+        [JsonProperty("code")]
+        public HttpStatusCode Code { get; set; }
+        [JsonProperty("details")]
+        public string Details { get; set; }
+    }
+}